Skip to content

Commit 04864af

Browse files
Aradhya Bhatiatomba
authored andcommitted
drm/bridge: cdns-dsi: Fix the _atomic_check()
Use the "adjusted_mode" for the dsi configuration check, as that is the more appropriate display_mode for validation, and later bridge enable. Also, fix the mode_valid_check parameter from false to true, as the dsi configuration check is taking place during the check-phase, and the crtc_* mode values are not expected to be populated yet. Fixes: a53d987 ("drm/bridge: cdns-dsi: Move DSI mode check to _atomic_check()") Signed-off-by: Aradhya Bhatia <aradhya.bhatia@linux.dev> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Tested-by: Jayesh Choudhary <j-choudhary@ti.com> Reviewed-by: Devarsh Thakkar <devarsht@ti.com> Link: https://lore.kernel.org/r/20250723-cdns-dsi-impro-v5-1-e61cc06074c2@ideasonboard.com Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
1 parent a3daf18 commit 04864af

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -997,10 +997,10 @@ static int cdns_dsi_bridge_atomic_check(struct drm_bridge *bridge,
997997
struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge);
998998
struct cdns_dsi *dsi = input_to_dsi(input);
999999
struct cdns_dsi_bridge_state *dsi_state = to_cdns_dsi_bridge_state(bridge_state);
1000-
const struct drm_display_mode *mode = &crtc_state->mode;
1000+
const struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode;
10011001
struct cdns_dsi_cfg *dsi_cfg = &dsi_state->dsi_cfg;
10021002

1003-
return cdns_dsi_check_conf(dsi, mode, dsi_cfg, false);
1003+
return cdns_dsi_check_conf(dsi, adjusted_mode, dsi_cfg, true);
10041004
}
10051005

10061006
static struct drm_bridge_state *

0 commit comments

Comments
 (0)