Skip to content

Commit 0955400

Browse files
compudjIngo Molnar
authored andcommitted
sched/membarrier: Remove redundant check
Checking that the number of threads is 1 is redundant with checking mm_users == 1. No change in functionality intended. Suggested-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Chris Metcalf <cmetcalf@ezchip.com> Cc: Christoph Lameter <cl@linux.com> Cc: Eric W. Biederman <ebiederm@xmission.com> Cc: Kirill Tkhai <tkhai@yandex.ru> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul E. McKenney <paulmck@linux.ibm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk> Cc: Thomas Gleixner <tglx@linutronix.de> Link: https://lkml.kernel.org/r/20190919173705.2181-3-mathieu.desnoyers@efficios.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent fc0d773 commit 0955400

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/sched/membarrier.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ static int membarrier_register_global_expedited(void)
186186
MEMBARRIER_STATE_GLOBAL_EXPEDITED_READY)
187187
return 0;
188188
atomic_or(MEMBARRIER_STATE_GLOBAL_EXPEDITED, &mm->membarrier_state);
189-
if (atomic_read(&mm->mm_users) == 1 && get_nr_threads(p) == 1) {
189+
if (atomic_read(&mm->mm_users) == 1) {
190190
/*
191191
* For single mm user, single threaded process, we can
192192
* simply issue a memory barrier after setting
@@ -232,7 +232,7 @@ static int membarrier_register_private_expedited(int flags)
232232
if (flags & MEMBARRIER_FLAG_SYNC_CORE)
233233
atomic_or(MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE,
234234
&mm->membarrier_state);
235-
if (!(atomic_read(&mm->mm_users) == 1 && get_nr_threads(p) == 1)) {
235+
if (atomic_read(&mm->mm_users) != 1) {
236236
/*
237237
* Ensure all future scheduler executions will observe the
238238
* new thread flag state for this process.

0 commit comments

Comments
 (0)