Skip to content

Commit 0a2e492

Browse files
simontrimmerbroonie
authored andcommitted
ASoC: cs35l56: Convert utility functions to use common data structure
Use the new cs35l56_base struct for utility functions. Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Acked-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20230721132120.5523-4-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent cf6e748 commit 0a2e492

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

sound/soc/codecs/cs35l56.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -802,14 +802,14 @@ static const struct reg_sequence cs35l56_system_reset_seq[] = {
802802
REG_SEQ0(CS35L56_DSP_VIRTUAL1_MBOX_1, CS35L56_MBOX_CMD_SYSTEM_RESET),
803803
};
804804

805-
static void cs35l56_system_reset(struct cs35l56_private *cs35l56, bool is_soundwire)
805+
static void cs35l56_system_reset(struct cs35l56_base *cs35l56_base, bool is_soundwire)
806806
{
807807
/*
808808
* Must enter cache-only first so there can't be any more register
809809
* accesses other than the controlled system reset sequence below.
810810
*/
811-
regcache_cache_only(cs35l56->base.regmap, true);
812-
regmap_multi_reg_write_bypassed(cs35l56->base.regmap,
811+
regcache_cache_only(cs35l56_base->regmap, true);
812+
regmap_multi_reg_write_bypassed(cs35l56_base->regmap,
813813
cs35l56_system_reset_seq,
814814
ARRAY_SIZE(cs35l56_system_reset_seq));
815815

@@ -818,7 +818,7 @@ static void cs35l56_system_reset(struct cs35l56_private *cs35l56, bool is_soundw
818818
return;
819819

820820
usleep_range(CS35L56_CONTROL_PORT_READY_US, CS35L56_CONTROL_PORT_READY_US + 400);
821-
regcache_cache_only(cs35l56->base.regmap, false);
821+
regcache_cache_only(cs35l56_base->regmap, false);
822822
}
823823

824824
static void cs35l56_secure_patch(struct cs35l56_private *cs35l56)
@@ -882,7 +882,7 @@ static void cs35l56_patch(struct cs35l56_private *cs35l56)
882882
init_completion(&cs35l56->init_completion);
883883

884884
cs35l56->soft_resetting = true;
885-
cs35l56_system_reset(cs35l56, !!cs35l56->sdw_peripheral);
885+
cs35l56_system_reset(&cs35l56->base, !!cs35l56->sdw_peripheral);
886886

887887
if (cs35l56->sdw_peripheral) {
888888
/*
@@ -1137,43 +1137,43 @@ int cs35l56_runtime_resume_common(struct cs35l56_private *cs35l56)
11371137
}
11381138
EXPORT_SYMBOL_NS_GPL(cs35l56_runtime_resume_common, SND_SOC_CS35L56_CORE);
11391139

1140-
static int cs35l56_is_fw_reload_needed(struct cs35l56_private *cs35l56)
1140+
static int cs35l56_is_fw_reload_needed(struct cs35l56_base *cs35l56_base)
11411141
{
11421142
unsigned int val;
11431143
int ret;
11441144

11451145
/* Nothing to re-patch if we haven't done any patching yet. */
1146-
if (!cs35l56->base.fw_patched)
1146+
if (!cs35l56_base->fw_patched)
11471147
return false;
11481148

11491149
/*
11501150
* If we have control of RESET we will have asserted it so the firmware
11511151
* will need re-patching.
11521152
*/
1153-
if (cs35l56->base.reset_gpio)
1153+
if (cs35l56_base->reset_gpio)
11541154
return true;
11551155

11561156
/*
11571157
* In secure mode FIRMWARE_MISSING is cleared by the BIOS loader so
11581158
* can't be used here to test for memory retention.
11591159
* Assume that tuning must be re-loaded.
11601160
*/
1161-
if (cs35l56->base.secured)
1161+
if (cs35l56_base->secured)
11621162
return true;
11631163

1164-
ret = pm_runtime_resume_and_get(cs35l56->base.dev);
1164+
ret = pm_runtime_resume_and_get(cs35l56_base->dev);
11651165
if (ret) {
1166-
dev_err(cs35l56->base.dev, "Failed to runtime_get: %d\n", ret);
1166+
dev_err(cs35l56_base->dev, "Failed to runtime_get: %d\n", ret);
11671167
return ret;
11681168
}
11691169

1170-
ret = regmap_read(cs35l56->base.regmap, CS35L56_PROTECTION_STATUS, &val);
1170+
ret = regmap_read(cs35l56_base->regmap, CS35L56_PROTECTION_STATUS, &val);
11711171
if (ret)
1172-
dev_err(cs35l56->base.dev, "Failed to read PROTECTION_STATUS: %d\n", ret);
1172+
dev_err(cs35l56_base->dev, "Failed to read PROTECTION_STATUS: %d\n", ret);
11731173
else
11741174
ret = !!(val & CS35L56_FIRMWARE_MISSING);
11751175

1176-
pm_runtime_put_autosuspend(cs35l56->base.dev);
1176+
pm_runtime_put_autosuspend(cs35l56_base->dev);
11771177

11781178
return ret;
11791179
}
@@ -1302,7 +1302,7 @@ int cs35l56_system_resume(struct device *dev)
13021302
if (!cs35l56->component)
13031303
return 0;
13041304

1305-
ret = cs35l56_is_fw_reload_needed(cs35l56);
1305+
ret = cs35l56_is_fw_reload_needed(&cs35l56->base);
13061306
dev_dbg(cs35l56->base.dev, "fw_reload_needed: %d\n", ret);
13071307
if (ret < 1)
13081308
return ret;
@@ -1547,7 +1547,7 @@ int cs35l56_init(struct cs35l56_private *cs35l56)
15471547
if (!cs35l56->base.reset_gpio) {
15481548
dev_dbg(cs35l56->base.dev, "No reset gpio: using soft reset\n");
15491549
cs35l56->soft_resetting = true;
1550-
cs35l56_system_reset(cs35l56, !!cs35l56->sdw_peripheral);
1550+
cs35l56_system_reset(&cs35l56->base, !!cs35l56->sdw_peripheral);
15511551
if (cs35l56->sdw_peripheral) {
15521552
/* Keep alive while we wait for re-enumeration */
15531553
pm_runtime_get_noresume(cs35l56->base.dev);

0 commit comments

Comments
 (0)