Skip to content

Commit 0a9ab9b

Browse files
Anderson LizardoGustavo Padovan
authored andcommitted
Bluetooth: Fix incorrect strncpy() in hidp_setup_hid()
The length parameter should be sizeof(req->name) - 1 because there is no guarantee that string provided by userspace will contain the trailing '\0'. Can be easily reproduced by manually setting req->name to 128 non-zero bytes prior to ioctl(HIDPCONNADD) and checking the device name setup on input subsystem: $ cat /sys/devices/pnp0/00\:04/tty/ttyS0/hci0/hci0\:1/input8/name AAAAAA[...]AAAAAAAAf0:af:f0:af:f0:af ("f0:af:f0:af:f0:af" is the device bluetooth address, taken from "phys" field in struct hid_device due to overflow.) Cc: stable@vger.kernel.org Signed-off-by: Anderson Lizardo <anderson.lizardo@openbossa.org> Acked-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
1 parent 2582d52 commit 0a9ab9b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/bluetooth/hidp/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -931,7 +931,7 @@ static int hidp_setup_hid(struct hidp_session *session,
931931
hid->version = req->version;
932932
hid->country = req->country;
933933

934-
strncpy(hid->name, req->name, 128);
934+
strncpy(hid->name, req->name, sizeof(req->name) - 1);
935935

936936
snprintf(hid->phys, sizeof(hid->phys), "%pMR",
937937
&bt_sk(session->ctrl_sock->sk)->src);

0 commit comments

Comments
 (0)