tc1100-wmi: Delete an unnecessary check before the function call "kfree"

elfring · dvhart · commit 0d44b410a01a · 2015-06-26T15:55:51.000-07:00
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring &lt;elfring@users.sourceforge.net&gt;
Signed-off-by: Darren Hart &lt;dvhart@linux.intel.com&gt;
diff --git a/drivers/platform/x86/tc1100-wmi.c b/drivers/platform/x86/tc1100-wmi.c
@@ -82,7 +82,7 @@ static int get_state(u32 *out, u8 instance)
 		tmp = 0;
 	}
 
-	if (result.length > 0 && result.pointer)
+	if (result.length > 0)
 		kfree(result.pointer);
 
 	switch (instance) {

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ static int get_state(u32 *out, u8 instance)`
`82`	`82`	`tmp = 0;`
`83`	`83`	`}`
`84`	`84`
`85`		`- if (result.length > 0 && result.pointer)`
	`85`	`+ if (result.length > 0)`
`86`	`86`	`kfree(result.pointer);`
`87`	`87`
`88`	`88`	`switch (instance) {`