Skip to content

Commit 18e8fea

Browse files
AnsuelPaolo Abeni
authored andcommitted
net: dsa: qca8k: limit user ports access to the first CPU port on setup
In preparation for multi-CPU support, set CPU port LOOKUP MEMBER outside the port loop and setup the LOOKUP MEMBER mask for user ports only to the first CPU port. This is to handle flooding condition where every CPU port is set as target and prevent packet duplication for unknown frames from user ports. Secondary CPU port LOOKUP MEMBER mask will be setup later when port_change_master will be implemented. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Link: https://lore.kernel.org/r/20230730074113.21889-3-ansuelsmth@gmail.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 23cfc71 commit 18e8fea

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

drivers/net/dsa/qca/qca8k-8xxx.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1850,18 +1850,16 @@ qca8k_setup(struct dsa_switch *ds)
18501850
if (ret)
18511851
return ret;
18521852

1853+
/* CPU port gets connected to all user ports of the switch */
1854+
ret = qca8k_rmw(priv, QCA8K_PORT_LOOKUP_CTRL(cpu_port),
1855+
QCA8K_PORT_LOOKUP_MEMBER, dsa_user_ports(ds));
1856+
if (ret)
1857+
return ret;
1858+
18531859
/* Setup connection between CPU port & user ports
18541860
* Configure specific switch configuration for ports
18551861
*/
18561862
for (i = 0; i < QCA8K_NUM_PORTS; i++) {
1857-
/* CPU port gets connected to all user ports of the switch */
1858-
if (dsa_is_cpu_port(ds, i)) {
1859-
ret = qca8k_rmw(priv, QCA8K_PORT_LOOKUP_CTRL(i),
1860-
QCA8K_PORT_LOOKUP_MEMBER, dsa_user_ports(ds));
1861-
if (ret)
1862-
return ret;
1863-
}
1864-
18651863
/* Individual user ports get connected to CPU port only */
18661864
if (dsa_is_user_port(ds, i)) {
18671865
ret = qca8k_rmw(priv, QCA8K_PORT_LOOKUP_CTRL(i),

0 commit comments

Comments
 (0)