Skip to content

Commit 1985026

Browse files
author
Linus Torvalds
committed
Revert drivers/ide/ide.c scsi_cmd_ioctl() usage changes
The old IDE driver is not ready to take generic SCSI commands, even if it uses them for some specific issues (ie the tray open/close ioctls for IDE CD-ROM's). Pointed out by Bartlomiej. I'm sure we'll have it fixed properly soon enough, but for now we should not allow it to cause problems. Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Cc: Jens Axboe <jens.axboe@oracle.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 8b0d416 commit 1985026

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/ide/ide.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,13 +1049,9 @@ int generic_ide_ioctl(ide_drive_t *drive, struct file *file, struct block_device
10491049
unsigned long flags;
10501050
ide_driver_t *drv;
10511051
void __user *p = (void __user *)arg;
1052-
int err, (*setfunc)(ide_drive_t *, int);
1052+
int err = 0, (*setfunc)(ide_drive_t *, int);
10531053
u8 *val;
10541054

1055-
err = scsi_cmd_ioctl(file, bdev->bd_disk->queue, bdev->bd_disk, cmd, p);
1056-
if (err != -ENOTTY)
1057-
return err;
1058-
10591055
switch (cmd) {
10601056
case HDIO_GET_32BIT: val = &drive->io_32bit; goto read_val;
10611057
case HDIO_GET_KEEPSETTINGS: val = &drive->keep_settings; goto read_val;
@@ -1175,6 +1171,10 @@ int generic_ide_ioctl(ide_drive_t *drive, struct file *file, struct block_device
11751171
return 0;
11761172
}
11771173

1174+
case CDROMEJECT:
1175+
case CDROMCLOSETRAY:
1176+
return scsi_cmd_ioctl(file, bdev->bd_disk->queue, bdev->bd_disk, cmd, p);
1177+
11781178
case HDIO_GET_BUSSTATE:
11791179
if (!capable(CAP_SYS_ADMIN))
11801180
return -EACCES;

0 commit comments

Comments
 (0)