Skip to content

Commit 1a3ed0d

Browse files
Alex Leibovichstorulf
authored andcommitted
mmc: sdhci-xenon: fix 1.8v regulator stabilization
Automatic Clock Gating is a feature used for the power consumption optimisation. It turned out that during early init phase it may prevent the stable voltage switch to 1.8V - due to that on some platforms an endless printout in dmesg can be observed: "mmc1: 1.8V regulator output did not became stable" Fix the problem by disabling the ACG at very beginning of the sdhci_init and let that be enabled later. Fixes: 3a3748d ("mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality") Signed-off-by: Alex Leibovich <alexl@marvell.com> Signed-off-by: Marcin Wojtas <mw@semihalf.com> Cc: stable@vger.kernel.org Acked-by: Adrian Hunter <adrian.hunter@intel.com> Link: https://lore.kernel.org/r/20201211141656.24915-1-mw@semihalf.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent ca1219c commit 1a3ed0d

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/mmc/host/sdhci-xenon.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,12 @@ static void xenon_reset_exit(struct sdhci_host *host,
168168
/* Disable tuning request and auto-retuning again */
169169
xenon_retune_setup(host);
170170

171-
xenon_set_acg(host, true);
171+
/*
172+
* The ACG should be turned off at the early init time, in order
173+
* to solve a possible issues with the 1.8V regulator stabilization.
174+
* The feature is enabled in later stage.
175+
*/
176+
xenon_set_acg(host, false);
172177

173178
xenon_set_sdclk_off_idle(host, sdhc_id, false);
174179

0 commit comments

Comments
 (0)