Skip to content

Commit 1c23b41

Browse files
arndbtorvalds
authored andcommitted
lib/ubsan.c: don't mark __ubsan_handle_builtin_unreachable as noreturn
gcc-8 complains about the prototype for this function: lib/ubsan.c:432:1: error: ignoring attribute 'noreturn' in declaration of a built-in function '__ubsan_handle_builtin_unreachable' because it conflicts with attribute 'const' [-Werror=attributes] This is actually a GCC's bug. In GCC internals __ubsan_handle_builtin_unreachable() declared with both 'noreturn' and 'const' attributes instead of only 'noreturn': https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84210 Workaround this by removing the noreturn attribute. [aryabinin: add information about GCC bug in changelog] Link: http://lkml.kernel.org/r/20181107144516.4587-1-aryabinin@virtuozzo.com Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com> Acked-by: Olof Johansson <olof@lixom.net> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 13c9aaf commit 1c23b41

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

lib/ubsan.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,8 +427,7 @@ void __ubsan_handle_shift_out_of_bounds(struct shift_out_of_bounds_data *data,
427427
EXPORT_SYMBOL(__ubsan_handle_shift_out_of_bounds);
428428

429429

430-
void __noreturn
431-
__ubsan_handle_builtin_unreachable(struct unreachable_data *data)
430+
void __ubsan_handle_builtin_unreachable(struct unreachable_data *data)
432431
{
433432
unsigned long flags;
434433

0 commit comments

Comments
 (0)