spi: core: Propagate error code of add_uevent_var()

andy-shev · broonie · commit 2856670f23a9 · 2017-07-26T15:30:35.000+01:00
add_uevent_var() can fail, let caller know about this.

Signed-off-by: Andy Shevchenko &lt;andriy.shevchenko@linux.intel.com&gt;
Signed-off-by: Mark Brown &lt;broonie@kernel.org&gt;
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
@@ -321,8 +321,7 @@ static int spi_uevent(struct device *dev, struct kobj_uevent_env *env)
 	if (rc != -ENODEV)
 		return rc;
 
-	add_uevent_var(env, "MODALIAS=%s%s", SPI_MODULE_PREFIX, spi->modalias);
-	return 0;
+	return add_uevent_var(env, "MODALIAS=%s%s", SPI_MODULE_PREFIX, spi->modalias);
 }
 
 struct bus_type spi_bus_type = {

Original file line number	Diff line number	Diff line change
`@@ -321,8 +321,7 @@ static int spi_uevent(struct device dev, struct kobj_uevent_env env)`
`321`	`321`	`if (rc != -ENODEV)`
`322`	`322`	`return rc;`
`323`	`323`
`324`		`- add_uevent_var(env, "MODALIAS=%s%s", SPI_MODULE_PREFIX, spi->modalias);`
`325`		`- return 0;`
	`324`	`+ return add_uevent_var(env, "MODALIAS=%s%s", SPI_MODULE_PREFIX, spi->modalias);`
`326`	`325`	`}`
`327`	`326`
`328`	`327`	`struct bus_type spi_bus_type = {`