net/smc: allow unprivileged users to read pnet table

Hans Wippel · davem330 · commit 29237d22bc45 · 2020-01-21T11:39:56.000+01:00
The current flags of the SMC_PNET_GET command only allow privileged
users to retrieve entries from the pnet table via netlink. The content
of the pnet table may be useful for all users though, e.g., for
debugging smc connection problems.

This patch removes the GENL_ADMIN_PERM flag so that unprivileged users
can read the pnet table.

Signed-off-by: Hans Wippel &lt;ndev@hwipl.net&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c
@@ -611,7 +611,7 @@ static const struct genl_ops smc_pnet_ops[] = {
 	{
 		.cmd = SMC_PNETID_GET,
 		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
-		.flags = GENL_ADMIN_PERM,
+		/* can be retrieved by unprivileged users */
 		.doit = smc_pnet_get,
 		.dumpit = smc_pnet_dump,
 		.start = smc_pnet_dump_start

Original file line number	Diff line number	Diff line change
`@@ -611,7 +611,7 @@ static const struct genl_ops smc_pnet_ops[] = {`
`611`	`611`	`{`
`612`	`612`	`.cmd = SMC_PNETID_GET,`
`613`	`613`	`.validate = GENL_DONT_VALIDATE_STRICT \| GENL_DONT_VALIDATE_DUMP,`
`614`		`- .flags = GENL_ADMIN_PERM,`
	`614`	`+ /* can be retrieved by unprivileged users */`
`615`	`615`	`.doit = smc_pnet_get,`
`616`	`616`	`.dumpit = smc_pnet_dump,`
`617`	`617`	`.start = smc_pnet_dump_start`