Skip to content

Commit 2a80c15

Browse files
novitollkuba-moo
authored andcommitted
net/qrtr: restrict user-controlled length in qrtr_tun_write_iter()
syzbot found WARNING in qrtr_tun_write_iter [1] when write_iter length exceeds KMALLOC_MAX_SIZE causing order >= MAX_ORDER condition. Additionally, there is no check for 0 length write. [1] WARNING: mm/page_alloc.c:5011 [..] Call Trace: alloc_pages_current+0x18c/0x2a0 mm/mempolicy.c:2267 alloc_pages include/linux/gfp.h:547 [inline] kmalloc_order+0x2e/0xb0 mm/slab_common.c:837 kmalloc_order_trace+0x14/0x120 mm/slab_common.c:853 kmalloc include/linux/slab.h:557 [inline] kzalloc include/linux/slab.h:682 [inline] qrtr_tun_write_iter+0x8a/0x180 net/qrtr/tun.c:83 call_write_iter include/linux/fs.h:1901 [inline] Reported-by: syzbot+c2a7e5c5211605a90865@syzkaller.appspotmail.com Signed-off-by: Sabyrzhan Tasbolatov <snovitoll@gmail.com> Link: https://lore.kernel.org/r/20210202092059.1361381-1-snovitoll@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent a4dc7ee commit 2a80c15

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

net/qrtr/tun.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,12 @@ static ssize_t qrtr_tun_write_iter(struct kiocb *iocb, struct iov_iter *from)
8080
ssize_t ret;
8181
void *kbuf;
8282

83+
if (!len)
84+
return -EINVAL;
85+
86+
if (len > KMALLOC_MAX_SIZE)
87+
return -ENOMEM;
88+
8389
kbuf = kzalloc(len, GFP_KERNEL);
8490
if (!kbuf)
8591
return -ENOMEM;

0 commit comments

Comments
 (0)