Skip to content

Commit 34e7434

Browse files
SamuelZOUdavem330
authored andcommitted
atm: nicstar: Fix possible use-after-free in nicstar_cleanup()
This module's remove path calls del_timer(). However, that function does not wait until the timer handler finishes. This means that the timer handler may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling del_timer_sync(), which makes sure the timer handler has finished, and unable to re-schedule itself. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent faa5f5d commit 34e7434

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/atm/nicstar.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ static void __exit nicstar_cleanup(void)
299299
{
300300
XPRINTK("nicstar: nicstar_cleanup() called.\n");
301301

302-
del_timer(&ns_timer);
302+
del_timer_sync(&ns_timer);
303303

304304
pci_unregister_driver(&nicstar_driver);
305305

0 commit comments

Comments
 (0)