Skip to content

Commit 35bcc91

Browse files
charliu-AMDENGalexdeucher
authored andcommitted
drm/amd/display: Insert dccg log for easy debug
[why] Log for sequence tracking Reviewed-by: Ovidiu (Ovi) Bunea <ovidiu.bunea@amd.com> Reviewed-by: Yihan Zhu <yihan.zhu@amd.com> Signed-off-by: Charlene Liu <Charlene.Liu@amd.com> Signed-off-by: Ivan Lipski <ivan.lipski@amd.com> Tested-by: Dan Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 19d8f31 commit 35bcc91

File tree

1 file changed

+21
-3
lines changed

1 file changed

+21
-3
lines changed

drivers/gpu/drm/amd/display/dc/dccg/dcn35/dcn35_dccg.c

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939

4040
#define CTX \
4141
dccg_dcn->base.ctx
42+
#include "logger_types.h"
4243
#define DC_LOGGER \
4344
dccg->ctx->logger
4445

@@ -1136,7 +1137,7 @@ static void dcn35_set_dppclk_enable(struct dccg *dccg,
11361137
default:
11371138
break;
11381139
}
1139-
//DC_LOG_DEBUG("%s: dpp_inst(%d) DPPCLK_EN = %d\n", __func__, dpp_inst, enable);
1140+
DC_LOG_DEBUG("%s: dpp_inst(%d) DPPCLK_EN = %d\n", __func__, dpp_inst, enable);
11401141

11411142
}
11421143

@@ -1406,6 +1407,10 @@ static void dccg35_set_dtbclk_dto(
14061407
* PIPEx_DTO_SRC_SEL should not be programmed during DTBCLK update since OTG may still be on, and the
14071408
* programming is handled in program_pix_clk() regardless, so it can be removed from here.
14081409
*/
1410+
DC_LOG_DEBUG("%s: OTG%d DTBCLK DTO enabled: pixclk_khz=%d, ref_dtbclk_khz=%d, req_dtbclk_khz=%d, phase=%d, modulo=%d\n",
1411+
__func__, params->otg_inst, params->pixclk_khz,
1412+
params->ref_dtbclk_khz, req_dtbclk_khz, phase, modulo);
1413+
14091414
} else {
14101415
switch (params->otg_inst) {
14111416
case 0:
@@ -1431,6 +1436,8 @@ static void dccg35_set_dtbclk_dto(
14311436

14321437
REG_WRITE(DTBCLK_DTO_MODULO[params->otg_inst], 0);
14331438
REG_WRITE(DTBCLK_DTO_PHASE[params->otg_inst], 0);
1439+
1440+
DC_LOG_DEBUG("%s: OTG%d DTBCLK DTO disabled\n", __func__, params->otg_inst);
14341441
}
14351442
}
14361443

@@ -1475,6 +1482,8 @@ static void dccg35_set_dpstreamclk(
14751482
BREAK_TO_DEBUGGER();
14761483
return;
14771484
}
1485+
DC_LOG_DEBUG("%s: dp_hpo_inst(%d) DPSTREAMCLK_EN = %d, DPSTREAMCLK_SRC_SEL = %d\n",
1486+
__func__, dp_hpo_inst, (src == REFCLK) ? 0 : 1, otg_inst);
14781487
}
14791488

14801489

@@ -1514,6 +1523,8 @@ static void dccg35_set_dpstreamclk_root_clock_gating(
15141523
BREAK_TO_DEBUGGER();
15151524
return;
15161525
}
1526+
DC_LOG_DEBUG("%s: dp_hpo_inst(%d) DPSTREAMCLK_ROOT_GATE_DISABLE = %d\n",
1527+
__func__, dp_hpo_inst, enable ? 1 : 0);
15171528
}
15181529

15191530

@@ -1553,7 +1564,7 @@ static void dccg35_set_physymclk_root_clock_gating(
15531564
BREAK_TO_DEBUGGER();
15541565
return;
15551566
}
1556-
//DC_LOG_DEBUG("%s: dpp_inst(%d) PHYESYMCLK_ROOT_GATE_DISABLE:\n", __func__, phy_inst, enable ? 0 : 1);
1567+
DC_LOG_DEBUG("%s: dpp_inst(%d) PHYESYMCLK_ROOT_GATE_DISABLE: %d\n", __func__, phy_inst, enable ? 0 : 1);
15571568

15581569
}
15591570

@@ -1626,6 +1637,8 @@ static void dccg35_set_physymclk(
16261637
BREAK_TO_DEBUGGER();
16271638
return;
16281639
}
1640+
DC_LOG_DEBUG("%s: phy_inst(%d) PHYxSYMCLK_EN = %d, PHYxSYMCLK_SRC_SEL = %d\n",
1641+
__func__, phy_inst, force_enable ? 1 : 0, clk_src);
16291642
}
16301643

16311644
static void dccg35_set_valid_pixel_rate(
@@ -1673,6 +1686,7 @@ static void dccg35_dpp_root_clock_control(
16731686
}
16741687

16751688
dccg->dpp_clock_gated[dpp_inst] = !clock_on;
1689+
DC_LOG_DEBUG("%s: dpp_inst(%d) clock_on = %d\n", __func__, dpp_inst, clock_on);
16761690
}
16771691

16781692
static void dccg35_disable_symclk32_se(
@@ -1731,14 +1745,14 @@ static void dccg35_disable_symclk32_se(
17311745
BREAK_TO_DEBUGGER();
17321746
return;
17331747
}
1748+
17341749
}
17351750

17361751
static void dccg35_init_cb(struct dccg *dccg)
17371752
{
17381753
(void)dccg;
17391754
/* Any RCG should be done when driver enter low power mode*/
17401755
}
1741-
17421756
void dccg35_init(struct dccg *dccg)
17431757
{
17441758
int otg_inst;
@@ -1753,6 +1767,8 @@ void dccg35_init(struct dccg *dccg)
17531767
for (otg_inst = 0; otg_inst < 2; otg_inst++) {
17541768
dccg31_disable_symclk32_le(dccg, otg_inst);
17551769
dccg31_set_symclk32_le_root_clock_gating(dccg, otg_inst, false);
1770+
DC_LOG_DEBUG("%s: OTG%d SYMCLK32_LE disabled and root clock gating disabled\n",
1771+
__func__, otg_inst);
17561772
}
17571773

17581774
// if (dccg->ctx->dc->debug.root_clock_optimization.bits.symclk32_se)
@@ -1765,6 +1781,8 @@ void dccg35_init(struct dccg *dccg)
17651781
dccg35_set_dpstreamclk(dccg, REFCLK, otg_inst,
17661782
otg_inst);
17671783
dccg35_set_dpstreamclk_root_clock_gating(dccg, otg_inst, false);
1784+
DC_LOG_DEBUG("%s: OTG%d DPSTREAMCLK disabled and root clock gating disabled\n",
1785+
__func__, otg_inst);
17681786
}
17691787

17701788
/*

0 commit comments

Comments
 (0)