Skip to content

Commit 368f899

Browse files
committed
Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull x86 fixes from Thomas Gleixner: "This contains the following fixes and improvements: - Avoid dereferencing an unprotected VMA pointer in the fault signal generation code - Fix inline asm call constraints for GCC 4.4 - Use existing register variable to retrieve the stack pointer instead of forcing the compiler to create another indirect access which results in excessive extra 'mov %rsp, %<dst>' instructions - Disable branch profiling for the memory encryption code to prevent an early boot crash - Fix a sparse warning caused by casting the __user annotation in __get_user_asm_u64() away - Fix an off by one error in the loop termination of the error patch in the x86 sysfs init code - Add missing CPU IDs to various Intel specific drivers to enable the functionality on recent hardware - More (init) constification in the numachip code" * 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: x86/asm: Use register variable to get stack pointer value x86/mm: Disable branch profiling in mem_encrypt.c x86/asm: Fix inline asm call constraints for GCC 4.4 perf/x86/intel/uncore: Correct num_boxes for IIO and IRP perf/x86/intel/rapl: Add missing CPU IDs perf/x86/msr: Add missing CPU IDs perf/x86/intel/cstate: Add missing CPU IDs x86: Don't cast away the __user in __get_user_asm_u64() x86/sysfs: Fix off-by-one error in loop termination x86/mm: Fix fault error path using unsafe vma pointer x86/numachip: Add const and __initconst to numachip2_clockevent
2 parents c42ed9f + 196bd48 commit 368f899

File tree

14 files changed

+56
-47
lines changed

14 files changed

+56
-47
lines changed

arch/x86/events/intel/cstate.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -552,6 +552,7 @@ static const struct x86_cpu_id intel_cstates_match[] __initconst = {
552552

553553
X86_CSTATES_MODEL(INTEL_FAM6_SKYLAKE_MOBILE, snb_cstates),
554554
X86_CSTATES_MODEL(INTEL_FAM6_SKYLAKE_DESKTOP, snb_cstates),
555+
X86_CSTATES_MODEL(INTEL_FAM6_SKYLAKE_X, snb_cstates),
555556

556557
X86_CSTATES_MODEL(INTEL_FAM6_KABYLAKE_MOBILE, snb_cstates),
557558
X86_CSTATES_MODEL(INTEL_FAM6_KABYLAKE_DESKTOP, snb_cstates),
@@ -560,6 +561,9 @@ static const struct x86_cpu_id intel_cstates_match[] __initconst = {
560561
X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNM, knl_cstates),
561562

562563
X86_CSTATES_MODEL(INTEL_FAM6_ATOM_GOLDMONT, glm_cstates),
564+
X86_CSTATES_MODEL(INTEL_FAM6_ATOM_DENVERTON, glm_cstates),
565+
566+
X86_CSTATES_MODEL(INTEL_FAM6_ATOM_GEMINI_LAKE, glm_cstates),
563567
{ },
564568
};
565569
MODULE_DEVICE_TABLE(x86cpu, intel_cstates_match);

arch/x86/events/intel/rapl.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -775,6 +775,9 @@ static const struct x86_cpu_id rapl_cpu_match[] __initconst = {
775775
X86_RAPL_MODEL_MATCH(INTEL_FAM6_KABYLAKE_DESKTOP, skl_rapl_init),
776776

777777
X86_RAPL_MODEL_MATCH(INTEL_FAM6_ATOM_GOLDMONT, hsw_rapl_init),
778+
X86_RAPL_MODEL_MATCH(INTEL_FAM6_ATOM_DENVERTON, hsw_rapl_init),
779+
780+
X86_RAPL_MODEL_MATCH(INTEL_FAM6_ATOM_GEMINI_LAKE, hsw_rapl_init),
778781
{},
779782
};
780783

arch/x86/events/intel/uncore_snbep.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3462,7 +3462,7 @@ static struct intel_uncore_ops skx_uncore_iio_ops = {
34623462
static struct intel_uncore_type skx_uncore_iio = {
34633463
.name = "iio",
34643464
.num_counters = 4,
3465-
.num_boxes = 5,
3465+
.num_boxes = 6,
34663466
.perf_ctr_bits = 48,
34673467
.event_ctl = SKX_IIO0_MSR_PMON_CTL0,
34683468
.perf_ctr = SKX_IIO0_MSR_PMON_CTR0,
@@ -3492,7 +3492,7 @@ static const struct attribute_group skx_uncore_format_group = {
34923492
static struct intel_uncore_type skx_uncore_irp = {
34933493
.name = "irp",
34943494
.num_counters = 2,
3495-
.num_boxes = 5,
3495+
.num_boxes = 6,
34963496
.perf_ctr_bits = 48,
34973497
.event_ctl = SKX_IRP0_MSR_PMON_CTL0,
34983498
.perf_ctr = SKX_IRP0_MSR_PMON_CTR0,

arch/x86/events/msr.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,14 @@ static bool test_intel(int idx)
6363
case INTEL_FAM6_ATOM_SILVERMONT1:
6464
case INTEL_FAM6_ATOM_SILVERMONT2:
6565
case INTEL_FAM6_ATOM_AIRMONT:
66+
67+
case INTEL_FAM6_ATOM_GOLDMONT:
68+
case INTEL_FAM6_ATOM_DENVERTON:
69+
70+
case INTEL_FAM6_ATOM_GEMINI_LAKE:
71+
72+
case INTEL_FAM6_XEON_PHI_KNL:
73+
case INTEL_FAM6_XEON_PHI_KNM:
6674
if (idx == PERF_MSR_SMI)
6775
return true;
6876
break;

arch/x86/include/asm/asm.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@
1111
# define __ASM_FORM_COMMA(x) " " #x ","
1212
#endif
1313

14-
#ifdef CONFIG_X86_32
14+
#ifndef __x86_64__
15+
/* 32 bit */
1516
# define __ASM_SEL(a,b) __ASM_FORM(a)
1617
# define __ASM_SEL_RAW(a,b) __ASM_FORM_RAW(a)
1718
#else
19+
/* 64 bit */
1820
# define __ASM_SEL(a,b) __ASM_FORM(b)
1921
# define __ASM_SEL_RAW(a,b) __ASM_FORM_RAW(b)
2022
#endif
@@ -139,8 +141,8 @@
139141
* gets set up by the containing function. If you forget to do this, objtool
140142
* may print a "call without frame pointer save/setup" warning.
141143
*/
142-
register unsigned int __asm_call_sp asm("esp");
143-
#define ASM_CALL_CONSTRAINT "+r" (__asm_call_sp)
144+
register unsigned long current_stack_pointer asm(_ASM_SP);
145+
#define ASM_CALL_CONSTRAINT "+r" (current_stack_pointer)
144146
#endif
145147

146148
#endif /* _ASM_X86_ASM_H */

arch/x86/include/asm/thread_info.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -158,17 +158,6 @@ struct thread_info {
158158
*/
159159
#ifndef __ASSEMBLY__
160160

161-
static inline unsigned long current_stack_pointer(void)
162-
{
163-
unsigned long sp;
164-
#ifdef CONFIG_X86_64
165-
asm("mov %%rsp,%0" : "=g" (sp));
166-
#else
167-
asm("mov %%esp,%0" : "=g" (sp));
168-
#endif
169-
return sp;
170-
}
171-
172161
/*
173162
* Walks up the stack frames to make sure that the specified object is
174163
* entirely contained by a single stack frame.

arch/x86/include/asm/uaccess.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ do { \
337337
_ASM_EXTABLE(1b, 4b) \
338338
_ASM_EXTABLE(2b, 4b) \
339339
: "=r" (retval), "=&A"(x) \
340-
: "m" (__m(__ptr)), "m" __m(((u32 *)(__ptr)) + 1), \
340+
: "m" (__m(__ptr)), "m" __m(((u32 __user *)(__ptr)) + 1), \
341341
"i" (errret), "0" (retval)); \
342342
})
343343

arch/x86/kernel/irq_32.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ static void call_on_stack(void *func, void *stack)
6464

6565
static inline void *current_stack(void)
6666
{
67-
return (void *)(current_stack_pointer() & ~(THREAD_SIZE - 1));
67+
return (void *)(current_stack_pointer & ~(THREAD_SIZE - 1));
6868
}
6969

7070
static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
@@ -88,7 +88,7 @@ static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
8888

8989
/* Save the next esp at the bottom of the stack */
9090
prev_esp = (u32 *)irqstk;
91-
*prev_esp = current_stack_pointer();
91+
*prev_esp = current_stack_pointer;
9292

9393
if (unlikely(overflow))
9494
call_on_stack(print_stack_overflow, isp);
@@ -139,7 +139,7 @@ void do_softirq_own_stack(void)
139139

140140
/* Push the previous esp onto the stack */
141141
prev_esp = (u32 *)irqstk;
142-
*prev_esp = current_stack_pointer();
142+
*prev_esp = current_stack_pointer;
143143

144144
call_on_stack(__do_softirq, isp);
145145
}

arch/x86/kernel/ksysfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ static int __init create_setup_data_nodes(struct kobject *parent)
299299
return 0;
300300

301301
out_clean_nodes:
302-
for (j = i - 1; j > 0; j--)
302+
for (j = i - 1; j >= 0; j--)
303303
cleanup_setup_data_node(*(kobjp + j));
304304
kfree(kobjp);
305305
out_setup_data_kobj:

arch/x86/kernel/traps.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ void ist_begin_non_atomic(struct pt_regs *regs)
142142
* from double_fault.
143143
*/
144144
BUG_ON((unsigned long)(current_top_of_stack() -
145-
current_stack_pointer()) >= THREAD_SIZE);
145+
current_stack_pointer) >= THREAD_SIZE);
146146

147147
preempt_enable_no_resched();
148148
}

0 commit comments

Comments
 (0)