Skip to content

Commit 38dfa56

Browse files
Saravana Kannangregkh
authored andcommitted
gpiolib: Clear the gpio_device's fwnode initialized flag before adding
Registering an irqdomain sets the flag for the fwnode. But having the flag set when a device is added is interpreted by fw_devlink to mean the device has already been initialized and will never probe. This prevents fw_devlink from creating device links with the gpio_device as a supplier. So, clear the flag before adding the device. Signed-off-by: Saravana Kannan <saravanak@google.com> Acked-by: Bartosz Golaszewski <brgl@bgdev.pl> Tested-by: Colin Foster <colin.foster@in-advantage.com> Tested-by: Sudeep Holla <sudeep.holla@arm.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Tested-by: Douglas Anderson <dianders@chromium.org> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> Tested-by: Luca Weiss <luca.weiss@fairphone.com> # qcom/sm7225-fairphone-fp4 Link: https://lore.kernel.org/r/20230207014207.1678715-5-saravanak@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 8640166 commit 38dfa56

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

drivers/gpio/gpiolib.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -578,6 +578,13 @@ static int gpiochip_setup_dev(struct gpio_device *gdev)
578578
{
579579
int ret;
580580

581+
/*
582+
* If fwnode doesn't belong to another device, it's safe to clear its
583+
* initialized flag.
584+
*/
585+
if (gdev->dev.fwnode && !gdev->dev.fwnode->dev)
586+
fwnode_dev_initialized(gdev->dev.fwnode, false);
587+
581588
ret = gcdev_register(gdev, gpio_devt);
582589
if (ret)
583590
return ret;

0 commit comments

Comments
 (0)