drm/bridge: ti-sn65dsi86: Use regmap_bulk_write API

andersson · robertfoss · commit 3c7a8600dec9 · 2021-10-27T17:02:33.000+02:00
The multi-register u16 write operation can use regmap_bulk_write() instead of two separate regmap_write() calls. It's uncertain if this has any effect on the actual updates of the underlying registers, but this at least gives the hardware the opportunity and saves us one transation on the bus. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Robert Foss <robert.foss@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20211025170925.3096444-2-bjorn.andersson@linaro.org
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -193,8 +193,9 @@ static const struct regmap_config ti_sn65dsi86_regmap_config = {
 static void ti_sn65dsi86_write_u16(struct ti_sn65dsi86 *pdata,
 				   unsigned int reg, u16 val)
 {
-	regmap_write(pdata->regmap, reg, val & 0xFF);
-	regmap_write(pdata->regmap, reg + 1, val >> 8);
+	u8 buf[2] = { val & 0xff, val >> 8 };
+
+	regmap_bulk_write(pdata->regmap, reg, buf, ARRAY_SIZE(buf));
 }
 
 static u32 ti_sn_bridge_get_dsi_freq(struct ti_sn65dsi86 *pdata)

Original file line number	Diff line number	Diff line change
`@@ -193,8 +193,9 @@ static const struct regmap_config ti_sn65dsi86_regmap_config = {`
`193`	`193`	`static void ti_sn65dsi86_write_u16(struct ti_sn65dsi86 *pdata,`
`194`	`194`	`unsigned int reg, u16 val)`
`195`	`195`	`{`
`196`		`- regmap_write(pdata->regmap, reg, val & 0xFF);`
`197`		`- regmap_write(pdata->regmap, reg + 1, val >> 8);`
	`196`	`+ u8 buf[2] = { val & 0xff, val >> 8 };`
	`197`	`+`
	`198`	`+ regmap_bulk_write(pdata->regmap, reg, buf, ARRAY_SIZE(buf));`
`198`	`199`	`}`
`199`	`200`
`200`	`201`	`static u32 ti_sn_bridge_get_dsi_freq(struct ti_sn65dsi86 *pdata)`