Skip to content

Commit 4205d37

Browse files
anjalisinghai1Jeff Kirsher
authored andcommitted
i40e: Avoid logs while adding/deleting FD-SB filters
It is not necessary to print FD filter add/delete log with normal debug settings because ethtool -n ethx shows all the FD-SB filters on an interface. The log can still be turned on through higher debug levels and it will continue to print a log if there was an error in the add/delete process. Change-ID: I67db2baf49e2075d2f537de40f7895e5b02cd610 Signed-off-by: Anjali Singhai Jain <anjali.singhai@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
1 parent 58ce517 commit 4205d37

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/ethernet/intel/i40e/i40e_txrx.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ static int i40e_add_del_fdir_udpv4(struct i40e_vsi *vsi,
228228
"PCTYPE:%d, Filter command send failed for fd_id:%d (ret = %d)\n",
229229
fd_data->pctype, fd_data->fd_id, ret);
230230
err = true;
231-
} else {
231+
} else if (I40E_DEBUG_FD & pf->hw.debug_mask) {
232232
if (add)
233233
dev_info(&pf->pdev->dev,
234234
"Filter OK for PCTYPE %d loc = %d\n",
@@ -303,7 +303,7 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi,
303303
"PCTYPE:%d, Filter command send failed for fd_id:%d (ret = %d)\n",
304304
fd_data->pctype, fd_data->fd_id, ret);
305305
err = true;
306-
} else {
306+
} else if (I40E_DEBUG_FD & pf->hw.debug_mask) {
307307
if (add)
308308
dev_info(&pf->pdev->dev, "Filter OK for PCTYPE %d loc = %d)\n",
309309
fd_data->pctype, fd_data->fd_id);
@@ -376,7 +376,7 @@ static int i40e_add_del_fdir_ipv4(struct i40e_vsi *vsi,
376376
"PCTYPE:%d, Filter command send failed for fd_id:%d (ret = %d)\n",
377377
fd_data->pctype, fd_data->fd_id, ret);
378378
err = true;
379-
} else {
379+
} else if (I40E_DEBUG_FD & pf->hw.debug_mask) {
380380
if (add)
381381
dev_info(&pf->pdev->dev,
382382
"Filter OK for PCTYPE %d loc = %d\n",

0 commit comments

Comments
 (0)