Skip to content

Commit 49963ee

Browse files
committed
Merge branch 'ibmvnic-napi-fixes'
Lijun Pan says: ==================== ibmvnic: correctly call NAPI APIs This series correct some misuse of NAPI APIs in the driver. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
2 parents 453a778 + 7c451f3 commit 49963ee

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

drivers/net/ethernet/ibm/ibmvnic.c

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1149,19 +1149,13 @@ static int __ibmvnic_open(struct net_device *netdev)
11491149

11501150
rc = set_link_state(adapter, IBMVNIC_LOGICAL_LNK_UP);
11511151
if (rc) {
1152-
for (i = 0; i < adapter->req_rx_queues; i++)
1153-
napi_disable(&adapter->napi[i]);
1152+
ibmvnic_napi_disable(adapter);
11541153
release_resources(adapter);
11551154
return rc;
11561155
}
11571156

11581157
netif_tx_start_all_queues(netdev);
11591158

1160-
if (prev_state == VNIC_CLOSED) {
1161-
for (i = 0; i < adapter->req_rx_queues; i++)
1162-
napi_schedule(&adapter->napi[i]);
1163-
}
1164-
11651159
adapter->state = VNIC_OPEN;
11661160
return rc;
11671161
}
@@ -1922,7 +1916,7 @@ static int do_reset(struct ibmvnic_adapter *adapter,
19221916
u64 old_num_rx_queues, old_num_tx_queues;
19231917
u64 old_num_rx_slots, old_num_tx_slots;
19241918
struct net_device *netdev = adapter->netdev;
1925-
int i, rc;
1919+
int rc;
19261920

19271921
netdev_dbg(adapter->netdev,
19281922
"[S:%d FOP:%d] Reset reason %d, reset_state %d\n",
@@ -2111,10 +2105,6 @@ static int do_reset(struct ibmvnic_adapter *adapter,
21112105
/* refresh device's multicast list */
21122106
ibmvnic_set_multi(netdev);
21132107

2114-
/* kick napi */
2115-
for (i = 0; i < adapter->req_rx_queues; i++)
2116-
napi_schedule(&adapter->napi[i]);
2117-
21182108
if (adapter->reset_reason == VNIC_RESET_FAILOVER ||
21192109
adapter->reset_reason == VNIC_RESET_MOBILITY)
21202110
__netdev_notify_peers(netdev);

0 commit comments

Comments
 (0)