Skip to content

Commit 56170ba

Browse files
xiaojiangfengdavem330
authored andcommitted
net: hisilicon: Use devm_platform_ioremap_resource
Use devm_platform_ioremap_resource instead of devm_ioremap_resource. Make the code simpler. Signed-off-by: Jiangfeng Xiao <xiaojiangfeng@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 752c2ea commit 56170ba

File tree

4 files changed

+7
-18
lines changed

4 files changed

+7
-18
lines changed

drivers/net/ethernet/hisilicon/hip04_eth.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,6 @@ static int hip04_mac_probe(struct platform_device *pdev)
899899
struct of_phandle_args arg;
900900
struct net_device *ndev;
901901
struct hip04_priv *priv;
902-
struct resource *res;
903902
int irq;
904903
int ret;
905904

@@ -912,16 +911,14 @@ static int hip04_mac_probe(struct platform_device *pdev)
912911
platform_set_drvdata(pdev, ndev);
913912
SET_NETDEV_DEV(ndev, &pdev->dev);
914913

915-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
916-
priv->base = devm_ioremap_resource(d, res);
914+
priv->base = devm_platform_ioremap_resource(pdev, 0);
917915
if (IS_ERR(priv->base)) {
918916
ret = PTR_ERR(priv->base);
919917
goto init_fail;
920918
}
921919

922920
#if defined(CONFIG_HI13X1_GMAC)
923-
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
924-
priv->sysctrl_base = devm_ioremap_resource(d, res);
921+
priv->sysctrl_base = devm_platform_ioremap_resource(pdev, 1);
925922
if (IS_ERR(priv->sysctrl_base)) {
926923
ret = PTR_ERR(priv->sysctrl_base);
927924
goto init_fail;

drivers/net/ethernet/hisilicon/hisi_femac.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -781,7 +781,6 @@ static int hisi_femac_drv_probe(struct platform_device *pdev)
781781
{
782782
struct device *dev = &pdev->dev;
783783
struct device_node *node = dev->of_node;
784-
struct resource *res;
785784
struct net_device *ndev;
786785
struct hisi_femac_priv *priv;
787786
struct phy_device *phy;
@@ -799,15 +798,13 @@ static int hisi_femac_drv_probe(struct platform_device *pdev)
799798
priv->dev = dev;
800799
priv->ndev = ndev;
801800

802-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
803-
priv->port_base = devm_ioremap_resource(dev, res);
801+
priv->port_base = devm_platform_ioremap_resource(pdev, 0);
804802
if (IS_ERR(priv->port_base)) {
805803
ret = PTR_ERR(priv->port_base);
806804
goto out_free_netdev;
807805
}
808806

809-
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
810-
priv->glb_base = devm_ioremap_resource(dev, res);
807+
priv->glb_base = devm_platform_ioremap_resource(pdev, 1);
811808
if (IS_ERR(priv->glb_base)) {
812809
ret = PTR_ERR(priv->glb_base);
813810
goto out_free_netdev;

drivers/net/ethernet/hisilicon/hix5hd2_gmac.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,7 +1097,6 @@ static int hix5hd2_dev_probe(struct platform_device *pdev)
10971097
const struct of_device_id *of_id = NULL;
10981098
struct net_device *ndev;
10991099
struct hix5hd2_priv *priv;
1100-
struct resource *res;
11011100
struct mii_bus *bus;
11021101
const char *mac_addr;
11031102
int ret;
@@ -1119,15 +1118,13 @@ static int hix5hd2_dev_probe(struct platform_device *pdev)
11191118
}
11201119
priv->hw_cap = (unsigned long)of_id->data;
11211120

1122-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
1123-
priv->base = devm_ioremap_resource(dev, res);
1121+
priv->base = devm_platform_ioremap_resource(pdev, 0);
11241122
if (IS_ERR(priv->base)) {
11251123
ret = PTR_ERR(priv->base);
11261124
goto out_free_netdev;
11271125
}
11281126

1129-
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
1130-
priv->ctrl_base = devm_ioremap_resource(dev, res);
1127+
priv->ctrl_base = devm_platform_ioremap_resource(pdev, 1);
11311128
if (IS_ERR(priv->ctrl_base)) {
11321129
ret = PTR_ERR(priv->ctrl_base);
11331130
goto out_free_netdev;

drivers/net/ethernet/hisilicon/hns_mdio.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,6 @@ static int hns_mdio_probe(struct platform_device *pdev)
417417
{
418418
struct hns_mdio_device *mdio_dev;
419419
struct mii_bus *new_bus;
420-
struct resource *res;
421420
int ret = -ENODEV;
422421

423422
if (!pdev) {
@@ -442,8 +441,7 @@ static int hns_mdio_probe(struct platform_device *pdev)
442441
new_bus->priv = mdio_dev;
443442
new_bus->parent = &pdev->dev;
444443

445-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
446-
mdio_dev->vbase = devm_ioremap_resource(&pdev->dev, res);
444+
mdio_dev->vbase = devm_platform_ioremap_resource(pdev, 0);
447445
if (IS_ERR(mdio_dev->vbase)) {
448446
ret = PTR_ERR(mdio_dev->vbase);
449447
return ret;

0 commit comments

Comments
 (0)