Skip to content

Commit 6171820

Browse files
committed
eth: mlx5: avoid iterator use outside of a loop
Fix the following warning about risky iterator use: drivers/net/ethernet/mellanox/mlx5/core/eq.c:1010 mlx5_comp_irq_get_affinity_mask() warn: iterator used outside loop: 'eq' Acked-by: Saeed Mahameed <saeed@kernel.org> Link: https://lore.kernel.org/r/20230420015802.815362-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 8c966a1 commit 6171820

File tree

1 file changed

+3
-2
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+3
-2
lines changed

drivers/net/ethernet/mellanox/mlx5/core/eq.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1070,10 +1070,11 @@ mlx5_comp_irq_get_affinity_mask(struct mlx5_core_dev *dev, int vector)
10701070

10711071
list_for_each_entry(eq, &table->comp_eqs_list, list) {
10721072
if (i++ == vector)
1073-
break;
1073+
return mlx5_irq_get_affinity_mask(eq->core.irq);
10741074
}
10751075

1076-
return mlx5_irq_get_affinity_mask(eq->core.irq);
1076+
WARN_ON_ONCE(1);
1077+
return NULL;
10771078
}
10781079
EXPORT_SYMBOL(mlx5_comp_irq_get_affinity_mask);
10791080

0 commit comments

Comments
 (0)