Skip to content

Commit 645d11d

Browse files
Matthew WilcoxKyle McMartin
authored andcommitted
[PARISC] lba_pci format warnings
Fix resource_size_t warnings in a variety of ways Signed-off-by: Matthew Wilcox <matthew@wil.cx> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
1 parent 19dd705 commit 645d11d

File tree

1 file changed

+29
-27
lines changed

1 file changed

+29
-27
lines changed

drivers/parisc/lba_pci.c

Lines changed: 29 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,8 @@ lba_dump_res(struct resource *r, int d)
168168

169169
printk(KERN_DEBUG "(%p)", r->parent);
170170
for (i = d; i ; --i) printk(" ");
171-
printk(KERN_DEBUG "%p [%lx,%lx]/%lx\n", r, r->start, r->end, r->flags);
171+
printk(KERN_DEBUG "%p [%lx,%lx]/%lx\n", r,
172+
(long)r->start, (long)r->end, r->flags);
172173
lba_dump_res(r->child, d+2);
173174
lba_dump_res(r->sibling, d);
174175
}
@@ -647,7 +648,7 @@ truncate_pat_collision(struct resource *root, struct resource *new)
647648
printk(KERN_WARNING "LBA: Truncating lmmio_space [%lx/%lx] "
648649
"to [%lx,%lx]\n",
649650
start, end,
650-
new->start, new->end );
651+
(long)new->start, (long)new->end );
651652

652653
return 0; /* truncation successful */
653654
}
@@ -715,8 +716,8 @@ lba_fixup_bus(struct pci_bus *bus)
715716

716717
printk("FAILED: lba_fixup_bus() request for "
717718
"elmmio_space [%lx/%lx]\n",
718-
ldev->hba.elmmio_space.start,
719-
ldev->hba.elmmio_space.end);
719+
(long)ldev->hba.elmmio_space.start,
720+
(long)ldev->hba.elmmio_space.end);
720721

721722
/* lba_dump_res(&iomem_resource, 2); */
722723
/* BUG(); */
@@ -738,15 +739,15 @@ lba_fixup_bus(struct pci_bus *bus)
738739
&(ldev->hba.lmmio_space))) {
739740

740741
printk(KERN_WARNING "LBA: lmmio_space [%lx/%lx] duplicate!\n",
741-
ldev->hba.lmmio_space.start,
742-
ldev->hba.lmmio_space.end);
742+
(long)ldev->hba.lmmio_space.start,
743+
(long)ldev->hba.lmmio_space.end);
743744
} else {
744745
err = request_resource(&iomem_resource, &(ldev->hba.lmmio_space));
745746
if (err < 0) {
746747
printk(KERN_ERR "FAILED: lba_fixup_bus() request for "
747748
"lmmio_space [%lx/%lx]\n",
748-
ldev->hba.lmmio_space.start,
749-
ldev->hba.lmmio_space.end);
749+
(long)ldev->hba.lmmio_space.start,
750+
(long)ldev->hba.lmmio_space.end);
750751
} else
751752
bus->resource[i++] = &(ldev->hba.lmmio_space);
752753
}
@@ -758,8 +759,8 @@ lba_fixup_bus(struct pci_bus *bus)
758759
if (err < 0) {
759760
printk("FAILED: lba_fixup_bus() request for "
760761
"gmmio_space [%lx/%lx]\n",
761-
ldev->hba.gmmio_space.start,
762-
ldev->hba.gmmio_space.end);
762+
(long)ldev->hba.gmmio_space.start,
763+
(long)ldev->hba.gmmio_space.end);
763764
lba_dump_res(&iomem_resource, 2);
764765
BUG();
765766
}
@@ -1063,16 +1064,16 @@ lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
10631064
/* used to fix up pre-initialized MEM BARs */
10641065
if (!lba_dev->hba.lmmio_space.start) {
10651066
sprintf(lba_dev->hba.lmmio_name,
1066-
"PCI%02lx LMMIO",
1067-
lba_dev->hba.bus_num.start);
1067+
"PCI%02x LMMIO",
1068+
(int)lba_dev->hba.bus_num.start);
10681069
lba_dev->hba.lmmio_space_offset = p->start -
10691070
io->start;
10701071
r = &lba_dev->hba.lmmio_space;
10711072
r->name = lba_dev->hba.lmmio_name;
10721073
} else if (!lba_dev->hba.elmmio_space.start) {
10731074
sprintf(lba_dev->hba.elmmio_name,
1074-
"PCI%02lx ELMMIO",
1075-
lba_dev->hba.bus_num.start);
1075+
"PCI%02x ELMMIO",
1076+
(int)lba_dev->hba.bus_num.start);
10761077
r = &lba_dev->hba.elmmio_space;
10771078
r->name = lba_dev->hba.elmmio_name;
10781079
} else {
@@ -1089,8 +1090,8 @@ lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
10891090

10901091
case PAT_GMMIO:
10911092
/* MMIO space > 4GB phys addr; for 64-bit BAR */
1092-
sprintf(lba_dev->hba.gmmio_name, "PCI%02lx GMMIO",
1093-
lba_dev->hba.bus_num.start);
1093+
sprintf(lba_dev->hba.gmmio_name, "PCI%02x GMMIO",
1094+
(int)lba_dev->hba.bus_num.start);
10941095
r = &lba_dev->hba.gmmio_space;
10951096
r->name = lba_dev->hba.gmmio_name;
10961097
r->start = p->start;
@@ -1112,8 +1113,8 @@ lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
11121113
*/
11131114
lba_dev->iop_base = ioremap_nocache(p->start, 64 * 1024 * 1024);
11141115

1115-
sprintf(lba_dev->hba.io_name, "PCI%02lx Ports",
1116-
lba_dev->hba.bus_num.start);
1116+
sprintf(lba_dev->hba.io_name, "PCI%02x Ports",
1117+
(int)lba_dev->hba.bus_num.start);
11171118
r = &lba_dev->hba.io_space;
11181119
r->name = lba_dev->hba.io_name;
11191120
r->start = HBA_PORT_BASE(lba_dev->hba.hba_num);
@@ -1166,8 +1167,8 @@ lba_legacy_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
11661167
** Legacy boxes but it's nice to see in /proc/iomem.
11671168
*/
11681169
r = &(lba_dev->hba.lmmio_space);
1169-
sprintf(lba_dev->hba.lmmio_name, "PCI%02lx LMMIO",
1170-
lba_dev->hba.bus_num.start);
1170+
sprintf(lba_dev->hba.lmmio_name, "PCI%02x LMMIO",
1171+
(int)lba_dev->hba.bus_num.start);
11711172
r->name = lba_dev->hba.lmmio_name;
11721173

11731174
#if 1
@@ -1275,8 +1276,8 @@ lba_legacy_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
12751276
** an existing (but unused portion of) distributed range.
12761277
*/
12771278
r = &(lba_dev->hba.elmmio_space);
1278-
sprintf(lba_dev->hba.elmmio_name, "PCI%02lx ELMMIO",
1279-
lba_dev->hba.bus_num.start);
1279+
sprintf(lba_dev->hba.elmmio_name, "PCI%02x ELMMIO",
1280+
(int)lba_dev->hba.bus_num.start);
12801281
r->name = lba_dev->hba.elmmio_name;
12811282

12821283
#if 1
@@ -1297,8 +1298,8 @@ lba_legacy_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
12971298
#endif
12981299

12991300
r = &(lba_dev->hba.io_space);
1300-
sprintf(lba_dev->hba.io_name, "PCI%02lx Ports",
1301-
lba_dev->hba.bus_num.start);
1301+
sprintf(lba_dev->hba.io_name, "PCI%02x Ports",
1302+
(int)lba_dev->hba.bus_num.start);
13021303
r->name = lba_dev->hba.io_name;
13031304
r->flags = IORESOURCE_IO;
13041305
r->start = READ_REG32(lba_dev->hba.base_addr + LBA_IOS_BASE) & ~1L;
@@ -1447,7 +1448,7 @@ lba_driver_probe(struct parisc_device *dev)
14471448
}
14481449

14491450
printk(KERN_INFO "Elroy version %s (0x%x) found at 0x%lx\n",
1450-
version, func_class & 0xf, dev->hpa.start);
1451+
version, func_class & 0xf, (long)dev->hpa.start);
14511452

14521453
if (func_class < 2) {
14531454
printk(KERN_WARNING "Can't support LBA older than "
@@ -1477,11 +1478,12 @@ lba_driver_probe(struct parisc_device *dev)
14771478
*/
14781479
printk(KERN_INFO "%s version TR%d.%d (0x%x) found at 0x%lx\n",
14791480
IS_MERCURY(dev) ? "Mercury" : "Quicksilver", major,
1480-
minor, func_class, dev->hpa.start);
1481+
minor, func_class, (long)dev->hpa.start);
14811482

14821483
cfg_ops = &mercury_cfg_ops;
14831484
} else {
1484-
printk(KERN_ERR "Unknown LBA found at 0x%lx\n", dev->hpa.start);
1485+
printk(KERN_ERR "Unknown LBA found at 0x%lx\n",
1486+
(long)dev->hpa.start);
14851487
return -ENODEV;
14861488
}
14871489

0 commit comments

Comments
 (0)