Skip to content

Commit 67ca515

Browse files
tq-schiffermkuba-moo
authored andcommitted
net: phy: micrel: make *-skew-ps check more lenient
It seems reasonable to fine-tune only some of the skew values when using one of the rgmii-*id PHY modes, and even when all skew values are specified, using the correct ID PHY mode makes sense for documentation purposes. Such a configuration also appears in the binding docs in Documentation/devicetree/bindings/net/micrel-ksz90x1.txt, so the driver should not warn about it. Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Link: https://lore.kernel.org/r/20211012103402.21438-1-matthias.schiffer@ew.tq-group.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent e15f597 commit 67ca515

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/phy/micrel.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -863,9 +863,9 @@ static int ksz9031_config_init(struct phy_device *phydev)
863863
MII_KSZ9031RN_TX_DATA_PAD_SKEW, 4,
864864
tx_data_skews, 4, &update);
865865

866-
if (update && phydev->interface != PHY_INTERFACE_MODE_RGMII)
866+
if (update && !phy_interface_is_rgmii(phydev))
867867
phydev_warn(phydev,
868-
"*-skew-ps values should be used only with phy-mode = \"rgmii\"\n");
868+
"*-skew-ps values should be used only with RGMII PHY modes\n");
869869

870870
/* Silicon Errata Sheet (DS80000691D or DS80000692D):
871871
* When the device links in the 1000BASE-T slave mode only,

0 commit comments

Comments
 (0)