staging: fsl-mc: move comparison before strcmp() call

tudorl · gregkh · commit 714cc27d41b5 · 2017-06-29T16:38:52.000+02:00
Move comparison before the strcmp() in this if statement, and slightly
increase efficiency by not making the strcmp() each time the if gets
evaluated but only when the comparison is true.
This was suggested in a review comment.

Signed-off-by: Laurentiu Tudor &lt;laurentiu.tudor@nxp.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -29,8 +29,9 @@ struct dprc_child_objs {
 static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
 				struct dprc_obj_desc *obj_desc)
 {
-	return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&
-		mc_dev->obj_desc.id == obj_desc->id;
+	return mc_dev->obj_desc.id == obj_desc->id &&
+	       !strcmp(mc_dev->obj_desc.type, obj_desc->type);
+
 }
 
 static int __fsl_mc_device_remove_if_not_in_mc(struct device *dev, void *data)

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,9 @@ struct dprc_child_objs {`
`29`	`29`	`static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,`
`30`	`30`	`struct dprc_obj_desc *obj_desc)`
`31`	`31`	`{`
`32`		`- return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&`
`33`		`- mc_dev->obj_desc.id == obj_desc->id;`
	`32`	`+ return mc_dev->obj_desc.id == obj_desc->id &&`
	`33`	`+ !strcmp(mc_dev->obj_desc.type, obj_desc->type);`
	`34`	`+`
`34`	`35`	`}`
`35`	`36`
`36`	`37`	`static int __fsl_mc_device_remove_if_not_in_mc(struct device dev, void data)`