Skip to content

Commit 735c095

Browse files
committed
genirq/cpuhotplug: Dont claim success on error
In case the affinity of an interrupt was broken, a printk is emitted. But if the affinity cannot be set at all due to a missing irq_set_affinity() callback or due to a failing callback, the message is still printed preceeded by a warning/error. That makes no sense whatsoever. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Jens Axboe <axboe@kernel.dk> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Keith Busch <keith.busch@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Christoph Hellwig <hch@lst.de> Link: http://lkml.kernel.org/r/20170619235445.274852976@linutronix.de
1 parent 0dd945f commit 735c095

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

kernel/irq/cpuhotplug.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,14 @@ static bool migrate_one_irq(struct irq_desc *desc)
3737
c = irq_data_get_irq_chip(d);
3838
if (!c->irq_set_affinity) {
3939
pr_debug("IRQ%u: unable to set affinity\n", d->irq);
40+
ret = false;
4041
} else {
4142
int r = irq_do_set_affinity(d, affinity, false);
42-
if (r)
43+
if (r) {
4344
pr_warn_ratelimited("IRQ%u: set affinity failed(%d).\n",
4445
d->irq, r);
46+
ret = false;
47+
}
4548
}
4649

4750
return ret;

0 commit comments

Comments
 (0)