Skip to content

Commit 793d316

Browse files
LuizOt31rodrigovivi
authored andcommitted
drm/i915: Remove struct_mutex in i915_irq.c
Remove struct_mutex from ivb_parity_work() function. The ivb_parity_work runs in a workqueue so it cannot race with itself. Also, it is not protecting anything with the other remaining usage of struct_mutex. Signed-off-by: Luiz Otavio Mello <luiz.mello@estudante.ufscar.br> Suggested-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://lore.kernel.org/r/20250908131518.36625-3-luiz.mello@estudante.ufscar.br Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 86a9fe8 commit 793d316

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/gpu/drm/i915/i915_irq.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,6 @@ static void ivb_parity_work(struct work_struct *work)
163163
u32 misccpctl;
164164
u8 slice = 0;
165165

166-
/* We must turn off DOP level clock gating to access the L3 registers.
167-
* In order to prevent a get/put style interface, acquire struct mutex
168-
* any time we access those registers.
169-
*/
170-
mutex_lock(&dev_priv->struct_mutex);
171166

172167
/* If we've screwed up tracking, just let the interrupt fire again */
173168
if (drm_WARN_ON(&dev_priv->drm, !dev_priv->l3_parity.which_slice))
@@ -225,7 +220,6 @@ static void ivb_parity_work(struct work_struct *work)
225220
gen5_gt_enable_irq(gt, GT_PARITY_ERROR(dev_priv));
226221
spin_unlock_irq(gt->irq_lock);
227222

228-
mutex_unlock(&dev_priv->struct_mutex);
229223
}
230224

231225
static irqreturn_t valleyview_irq_handler(int irq, void *arg)

0 commit comments

Comments
 (0)