Skip to content

Commit 7a74c12

Browse files
miquelraynalPaolo Abeni
authored andcommitted
net: mvpp2: Consider NVMEM cells as possible MAC address source
The ONIE standard describes the organization of tlv (type-length-value) arrays commonly stored within NVMEM devices on common networking hardware. Several drivers already make use of NVMEM cells for purposes like retrieving a default MAC address provided by the manufacturer. What made ONIE tables unusable so far was the fact that the information where "dynamically" located within the table depending on the manufacturer wishes, while Linux NVMEM support only allowed statically defined NVMEM cells. Fortunately, this limitation was eventually tackled with the introduction of discoverable cells through the use of NVMEM layouts, making it possible to extract and consistently use the content of tables like ONIE's tlv arrays. Parsing this table at runtime in order to get various information is now possible. So, because many Marvell networking switches already follow this standard, let's consider using NVMEM cells as a new valid source of information when looking for a base MAC address, which is one of the primary uses of these new fields. Indeed, manufacturers following the ONIE standard are encouraged to provide a default MAC address there, so let's eventually use it if no other MAC address has been found using the existing methods. Link: https://opencomputeproject.github.io/onie/design-spec/hw_requirements.html Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent a48acad commit 7a74c12

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6104,6 +6104,13 @@ static void mvpp2_port_copy_mac_addr(struct net_device *dev, struct mvpp2 *priv,
61046104
}
61056105
}
61066106

6107+
/* Only valid on OF enabled platforms */
6108+
if (!of_get_mac_address_nvmem(to_of_node(fwnode), fw_mac_addr)) {
6109+
*mac_from = "nvmem cell";
6110+
eth_hw_addr_set(dev, fw_mac_addr);
6111+
return;
6112+
}
6113+
61076114
*mac_from = "random";
61086115
eth_hw_addr_random(dev);
61096116
}

0 commit comments

Comments
 (0)