Skip to content

Commit 7bca2b2

Browse files
geertukuba-moo
authored andcommitted
net: renesas: rswitch: Convert to for_each_available_child_of_node()
Simplify rswitch_get_port_node() by using the for_each_available_child_of_node() helper instead of manually ignoring unavailable child nodes, and leaking a reference. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/54f544d573a64b96e01fd00d3481b10806f4d110.1738771798.git.geert+renesas@glider.be Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 02c9722 commit 7bca2b2

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

drivers/net/ethernet/renesas/rswitch.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1287,17 +1287,14 @@ static struct device_node *rswitch_get_port_node(struct rswitch_device *rdev)
12871287
if (!ports)
12881288
return NULL;
12891289

1290-
for_each_child_of_node(ports, port) {
1290+
for_each_available_child_of_node(ports, port) {
12911291
err = of_property_read_u32(port, "reg", &index);
12921292
if (err < 0) {
12931293
port = NULL;
12941294
goto out;
12951295
}
1296-
if (index == rdev->etha->index) {
1297-
if (!of_device_is_available(port))
1298-
port = NULL;
1296+
if (index == rdev->etha->index)
12991297
break;
1300-
}
13011298
}
13021299

13031300
out:

0 commit comments

Comments
 (0)