Skip to content

Commit 8128ac3

Browse files
Paul Gortmakerjoergroedel
authored andcommitted
iommu/ipmmu-vmsa: Make it explicitly non-modular
The Kconfig currently controlling compilation of this code is: drivers/iommu/Kconfig:config IPMMU_VMSA drivers/iommu/Kconfig: bool "Renesas VMSA-compatible IPMMU" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_init was not even used by this driver, the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. Cc: Joerg Roedel <joro@8bytes.org> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: iommu@lists.linux-foundation.org Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent d4cf5bb commit 8128ac3

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

drivers/iommu/ipmmu-vmsa.c

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// SPDX-License-Identifier: GPL-2.0
22
/*
3-
* IPMMU VMSA
3+
* IOMMU API for Renesas VMSA-compatible IPMMU
4+
* Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
45
*
56
* Copyright (C) 2014 Renesas Electronics Corporation
67
*/
@@ -11,10 +12,10 @@
1112
#include <linux/dma-mapping.h>
1213
#include <linux/err.h>
1314
#include <linux/export.h>
15+
#include <linux/init.h>
1416
#include <linux/interrupt.h>
1517
#include <linux/io.h>
1618
#include <linux/iommu.h>
17-
#include <linux/module.h>
1819
#include <linux/of.h>
1920
#include <linux/of_device.h>
2021
#include <linux/of_iommu.h>
@@ -957,8 +958,6 @@ static const struct of_device_id ipmmu_of_ids[] = {
957958
},
958959
};
959960

960-
MODULE_DEVICE_TABLE(of, ipmmu_of_ids);
961-
962961
static int ipmmu_probe(struct platform_device *pdev)
963962
{
964963
struct ipmmu_vmsa_device *mmu;
@@ -1129,15 +1128,4 @@ static int __init ipmmu_init(void)
11291128
setup_done = true;
11301129
return 0;
11311130
}
1132-
1133-
static void __exit ipmmu_exit(void)
1134-
{
1135-
return platform_driver_unregister(&ipmmu_driver);
1136-
}
1137-
11381131
subsys_initcall(ipmmu_init);
1139-
module_exit(ipmmu_exit);
1140-
1141-
MODULE_DESCRIPTION("IOMMU API for Renesas VMSA-compatible IPMMU");
1142-
MODULE_AUTHOR("Laurent Pinchart <laurent.pinchart@ideasonboard.com>");
1143-
MODULE_LICENSE("GPL v2");

0 commit comments

Comments
 (0)