Skip to content

Commit 84f9017

Browse files
FlyGoatrafaeljw
authored andcommitted
ACPI: platform-profile: Introduce object pointers to callbacks
Add an object pointer to handler callbacks to avoid the need for drivers to have a global variable to get to their driver-data struct. Link: https://lore.kernel.org/linux-acpi/6a29f338-d9e4-150c-81dd-2ffb54f5bc35@redhat.com/ Link: https://lore.kernel.org/r/20210114073429.176462-3-jiaxun.yang@flygoat.com Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Suggested-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 9d56653 commit 84f9017

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

drivers/acpi/platform_profile.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ static ssize_t platform_profile_show(struct device *dev,
6464
return -ENODEV;
6565
}
6666

67-
err = cur_profile->profile_get(&profile);
67+
err = cur_profile->profile_get(cur_profile, &profile);
6868
mutex_unlock(&profile_lock);
6969
if (err)
7070
return err;
@@ -104,7 +104,7 @@ static ssize_t platform_profile_store(struct device *dev,
104104
return -EOPNOTSUPP;
105105
}
106106

107-
err = cur_profile->profile_set(i);
107+
err = cur_profile->profile_set(cur_profile, i);
108108
mutex_unlock(&profile_lock);
109109
if (err)
110110
return err;

include/linux/platform_profile.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@ enum platform_profile_option {
2828

2929
struct platform_profile_handler {
3030
unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
31-
int (*profile_get)(enum platform_profile_option *profile);
32-
int (*profile_set)(enum platform_profile_option profile);
31+
int (*profile_get)(struct platform_profile_handler *pprof,
32+
enum platform_profile_option *profile);
33+
int (*profile_set)(struct platform_profile_handler *pprof,
34+
enum platform_profile_option profile);
3335
};
3436

3537
int platform_profile_register(struct platform_profile_handler *pprof);

0 commit comments

Comments
 (0)