Skip to content

Commit 86ecd3b

Browse files
committed
drm/i915/dsi: Do panel power on + reset deassert earlier on icl+
Looks like we're trying to talk to the DSI panel even before turning it on, on icl+. Bspec doesn't actually specify when these should be done, but certainly we need to turn the panel on at least before talking to it. So let's move the power on + reset deassert steps to be the first thing we do. This is also what Windows does. v2: s/intel_dsi_msleep/msleep/ Reviewed-by: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230608203057.23759-2-ville.syrjala@linux.intel.com
1 parent b02a9a0 commit 86ecd3b

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

drivers/gpu/drm/i915/display/icl_dsi.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1138,10 +1138,6 @@ static void gen11_dsi_powerup_panel(struct intel_encoder *encoder)
11381138
"error setting max return pkt size%d\n", tmp);
11391139
}
11401140

1141-
/* panel power on related mipi dsi vbt sequences */
1142-
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_POWER_ON);
1143-
msleep(intel_dsi->panel_on_delay);
1144-
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_DEASSERT_RESET);
11451141
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_INIT_OTP);
11461142
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_DISPLAY_ON);
11471143

@@ -1154,6 +1150,12 @@ static void gen11_dsi_pre_pll_enable(struct intel_atomic_state *state,
11541150
const struct intel_crtc_state *crtc_state,
11551151
const struct drm_connector_state *conn_state)
11561152
{
1153+
struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1154+
1155+
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_POWER_ON);
1156+
msleep(intel_dsi->panel_on_delay);
1157+
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_DEASSERT_RESET);
1158+
11571159
/* step2: enable IO power */
11581160
gen11_dsi_enable_io_power(encoder);
11591161

0 commit comments

Comments
 (0)