ftrace: Set direct_ops storage-class-specifier to static

Tom Rix · rostedt · commit 873256554901 · 2023-03-19T12:20:49.000-04:00
smatch reports this warning kernel/trace/ftrace.c:2594:19: warning: symbol 'direct_ops' was not declared. Should it be static? The variable direct_ops is only used in ftrace.c, so it should be static Link: https://lore.kernel.org/linux-trace-kernel/20230311135113.711824-1-trix@redhat.com Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
@@ -2503,7 +2503,7 @@ static void call_direct_funcs(unsigned long ip, unsigned long pip,
 	arch_ftrace_set_direct_caller(fregs, addr);
 }
 
-struct ftrace_ops direct_ops = {
+static struct ftrace_ops direct_ops = {
 	.func		= call_direct_funcs,
 	.flags		= FTRACE_OPS_FL_DIRECT | FTRACE_OPS_FL_SAVE_REGS
 			  | FTRACE_OPS_FL_PERMANENT,

Original file line number	Diff line number	Diff line change
`@@ -2503,7 +2503,7 @@ static void call_direct_funcs(unsigned long ip, unsigned long pip,`
`2503`	`2503`	`arch_ftrace_set_direct_caller(fregs, addr);`
`2504`	`2504`	`}`
`2505`	`2505`
`2506`		`-struct ftrace_ops direct_ops = {`
	`2506`	`+static struct ftrace_ops direct_ops = {`
`2507`	`2507`	`.func = call_direct_funcs,`
`2508`	`2508`	`.flags = FTRACE_OPS_FL_DIRECT \| FTRACE_OPS_FL_SAVE_REGS`
`2509`	`2509`	`\| FTRACE_OPS_FL_PERMANENT,`