Skip to content

Commit 8733a06

Browse files
tursulinickle
authored andcommitted
drm/i915: Adjust the sentinel assert to match implementation
Sentinels are supposed to be last requests in the elsp queue, not the only one, so adjust the assert accordingly. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200607222108.14401-1-chris@chris-wilson.co.uk Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
1 parent 46d53e2 commit 8733a06

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

drivers/gpu/drm/i915/gt/intel_lrc.c

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1635,9 +1635,9 @@ assert_pending_valid(const struct intel_engine_execlists *execlists,
16351635
ccid = ce->lrc.ccid;
16361636

16371637
/*
1638-
* Sentinels are supposed to be lonely so they flush the
1639-
* current exection off the HW. Check that they are the
1640-
* only request in the pending submission.
1638+
* Sentinels are supposed to be the last request so they flush
1639+
* the current execution off the HW. Check that they are the only
1640+
* request in the pending submission.
16411641
*/
16421642
if (sentinel) {
16431643
GEM_TRACE_ERR("%s: context:%llx after sentinel in pending[%zd]\n",
@@ -1646,15 +1646,7 @@ assert_pending_valid(const struct intel_engine_execlists *execlists,
16461646
port - execlists->pending);
16471647
return false;
16481648
}
1649-
16501649
sentinel = i915_request_has_sentinel(rq);
1651-
if (sentinel && port != execlists->pending) {
1652-
GEM_TRACE_ERR("%s: sentinel context:%llx not in prime position[%zd]\n",
1653-
engine->name,
1654-
ce->timeline->fence_context,
1655-
port - execlists->pending);
1656-
return false;
1657-
}
16581650

16591651
/* Hold tightly onto the lock to prevent concurrent retires! */
16601652
if (!spin_trylock_irqsave(&rq->lock, flags))

0 commit comments

Comments
 (0)