bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

Dan Carpenter · davem330 · commit 92425c40676d · 2017-12-06T14:25:25.000-05:00
Smatch warns that: drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() error: uninitialized symbol 'rc'. "rc" is either uninitialized or set to zero here so we can just remove the check. Fixes: 8c95f77 ("bnxt_en: add support for Flower based vxlan encap/decap offload") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
@@ -148,9 +148,6 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
 		}
 	}
 
-	if (rc)
-		return rc;
-
 	if (actions->flags & BNXT_TC_ACTION_FLAG_FWD) {
 		if (actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_ENCAP) {
 			/* dst_fid is PF's fid */
@@ -164,7 +161,7 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
 		}
 	}
 
-	return rc;
+	return 0;
 }
 
 #define GET_KEY(flow_cmd, key_type)					\

Original file line number	Diff line number	Diff line change
`@@ -148,9 +148,6 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,`
`148`	`148`	`}`
`149`	`149`	`}`
`150`	`150`
`151`		`- if (rc)`
`152`		`- return rc;`
`153`		`-`
`154`	`151`	`if (actions->flags & BNXT_TC_ACTION_FLAG_FWD) {`
`155`	`152`	`if (actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_ENCAP) {`
`156`	`153`	`/* dst_fid is PF's fid */`
`@@ -164,7 +161,7 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,`
`164`	`161`	`}`
`165`	`162`	`}`
`166`	`163`
`167`		`- return rc;`
	`164`	`+ return 0;`
`168`	`165`	`}`
`169`	`166`
`170`	`167`	`#define GET_KEY(flow_cmd, key_type) \`