Skip to content

Commit 96bd1d5

Browse files
committed
drm/i915/display: drop unnecessary i915_drv.h includes
Now that we don't include i915_drv.h via any headers from display, we can reliably remove unnecessary i915_drv.h includes and be sure they're not indirectly included. Add other includes where needed. v2: Fix 32-bit build Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20241217132147.2008057-1-jani.nikula@intel.com Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent f9d4185 commit 96bd1d5

21 files changed

+30
-27
lines changed

drivers/gpu/drm/i915/display/dvo_ns2501.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
*
2727
*/
2828

29-
#include "i915_drv.h"
3029
#include "intel_display_types.h"
3130
#include "intel_dvo_dev.h"
3231

drivers/gpu/drm/i915/display/i9xx_display_sr.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
* Copyright © 2024 Intel Corporation
44
*/
55

6-
#include "i915_drv.h"
6+
#include <drm/drm_device.h>
7+
78
#include "i915_reg.h"
89
#include "i9xx_display_sr.h"
910
#include "i9xx_wm_regs.h"

drivers/gpu/drm/i915/display/intel_acpi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99
#include <linux/acpi.h>
1010
#include <acpi/video.h>
1111

12-
#include "i915_drv.h"
12+
#include "i915_utils.h"
1313
#include "intel_acpi.h"
14+
#include "intel_display_core.h"
1415
#include "intel_display_types.h"
1516

1617
#define INTEL_DSM_REVISION_ID 1 /* For Calpella anyway... */

drivers/gpu/drm/i915/display/intel_alpm.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
#include <linux/debugfs.h>
77

8-
#include "i915_drv.h"
98
#include "intel_alpm.h"
109
#include "intel_crtc.h"
1110
#include "intel_de.h"

drivers/gpu/drm/i915/display/intel_display_debugfs_params.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@
77
#include <linux/kernel.h>
88

99
#include <drm/drm_drv.h>
10+
#include <drm/drm_file.h>
1011

12+
#include "intel_display_core.h"
1113
#include "intel_display_debugfs_params.h"
12-
#include "i915_drv.h"
1314
#include "intel_display_params.h"
1415

1516
/* int param */

drivers/gpu/drm/i915/display/intel_display_params.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,13 @@
33
* Copyright © 2023 Intel Corporation
44
*/
55

6+
#include <linux/moduleparam.h>
7+
#include <linux/slab.h>
8+
#include <linux/string_choices.h>
9+
10+
#include <drm/drm_print.h>
11+
612
#include "intel_display_params.h"
7-
#include "i915_drv.h"
813

914
#define intel_display_param_named(name, T, perm, desc) \
1015
module_param_named(name, intel_display_modparams.name, T, perm); \

drivers/gpu/drm/i915/display/intel_display_power_map.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,12 @@
33
* Copyright © 2022 Intel Corporation
44
*/
55

6-
#include "i915_drv.h"
76
#include "i915_reg.h"
8-
9-
#include "vlv_sideband_reg.h"
10-
7+
#include "intel_display_core.h"
118
#include "intel_display_power_map.h"
129
#include "intel_display_power_well.h"
1310
#include "intel_display_types.h"
11+
#include "vlv_sideband_reg.h"
1412

1513
#define __LIST_INLINE_ELEMS(__elem_type, ...) \
1614
((__elem_type[]) { __VA_ARGS__ })

drivers/gpu/drm/i915/display/intel_display_snapshot.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33

44
#include <linux/slab.h>
55

6-
#include "i915_drv.h"
6+
#include <drm/drm_drv.h>
7+
8+
#include "intel_display_core.h"
79
#include "intel_display_device.h"
810
#include "intel_display_params.h"
911
#include "intel_display_snapshot.h"

drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,9 @@
3434
* for some reason.
3535
*/
3636

37-
#include "i915_drv.h"
37+
#include "i915_utils.h"
3838
#include "intel_backlight.h"
39+
#include "intel_display_core.h"
3940
#include "intel_display_types.h"
4041
#include "intel_dp.h"
4142
#include "intel_dp_aux_backlight.h"

drivers/gpu/drm/i915/display/intel_dp_hdcp.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include <drm/display/drm_hdcp_helper.h>
1212
#include <drm/drm_print.h>
1313

14-
#include "i915_drv.h"
1514
#include "i915_reg.h"
1615
#include "intel_ddi.h"
1716
#include "intel_de.h"

0 commit comments

Comments
 (0)