NTB: Fix range check on memory window index

Allen Hubbe · jonmason · commit 9a07826f9903 · 2015-09-07T15:27:12.000-04:00
The range check must exclude the upper bound.

Signed-off-by: Allen Hubbe &lt;Allen.Hubbe@emc.com&gt;
Signed-off-by: Jon Mason &lt;jdmason@kudzu.us&gt;
diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
@@ -240,7 +240,7 @@ static inline int ndev_ignore_unsafe(struct intel_ntb_dev *ndev,
 
 static int ndev_mw_to_bar(struct intel_ntb_dev *ndev, int idx)
 {
-	if (idx < 0 || idx > ndev->mw_count)
+	if (idx < 0 || idx >= ndev->mw_count)
 		return -EINVAL;
 	return ndev->reg->mw_bar[idx];
 }

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ static inline int ndev_ignore_unsafe(struct intel_ntb_dev *ndev,`
`240`	`240`
`241`	`241`	`static int ndev_mw_to_bar(struct intel_ntb_dev *ndev, int idx)`
`242`	`242`	`{`
`243`		`- if (idx < 0 \|\| idx > ndev->mw_count)`
	`243`	`+ if (idx < 0 \|\| idx >= ndev->mw_count)`
`244`	`244`	`return -EINVAL;`
`245`	`245`	`return ndev->reg->mw_bar[idx];`
`246`	`246`	`}`