Skip to content

Commit 9d599f2

Browse files
LorenzoBianconinbd168
authored andcommitted
wifi: mt76: mt7615: rely on shared poll_list field
Rely on poll_list field in mt76_wcid structure and get rid of private copy. Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by: Felix Fietkau <nbd@nbd.name>
1 parent 2d29058 commit 9d599f2

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

drivers/net/wireless/mediatek/mt76/mt7615/mac.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -388,8 +388,8 @@ static int mt7615_mac_fill_rx(struct mt7615_dev *dev, struct sk_buff *skb)
388388

389389
msta = container_of(status->wcid, struct mt7615_sta, wcid);
390390
spin_lock_bh(&dev->mt76.sta_poll_lock);
391-
if (list_empty(&msta->poll_list))
392-
list_add_tail(&msta->poll_list,
391+
if (list_empty(&msta->wcid.poll_list))
392+
list_add_tail(&msta->wcid.poll_list,
393393
&dev->mt76.sta_poll_list);
394394
spin_unlock_bh(&dev->mt76.sta_poll_lock);
395395
}
@@ -914,10 +914,10 @@ void mt7615_mac_sta_poll(struct mt7615_dev *dev)
914914
bool clear = false;
915915

916916
msta = list_first_entry(&sta_poll_list, struct mt7615_sta,
917-
poll_list);
917+
wcid.poll_list);
918918

919919
spin_lock_bh(&dev->mt76.sta_poll_lock);
920-
list_del_init(&msta->poll_list);
920+
list_del_init(&msta->wcid.poll_list);
921921
spin_unlock_bh(&dev->mt76.sta_poll_lock);
922922

923923
addr = mt7615_mac_wtbl_addr(dev, msta->wcid.idx) + 19 * 4;
@@ -1516,8 +1516,8 @@ static void mt7615_mac_add_txs(struct mt7615_dev *dev, void *data)
15161516
sta = wcid_to_sta(wcid);
15171517

15181518
spin_lock_bh(&dev->mt76.sta_poll_lock);
1519-
if (list_empty(&msta->poll_list))
1520-
list_add_tail(&msta->poll_list, &dev->mt76.sta_poll_list);
1519+
if (list_empty(&msta->wcid.poll_list))
1520+
list_add_tail(&msta->wcid.poll_list, &dev->mt76.sta_poll_list);
15211521
spin_unlock_bh(&dev->mt76.sta_poll_lock);
15221522

15231523
if (mt7615_mac_add_txs_skb(dev, msta, pid, txs_data))

drivers/net/wireless/mediatek/mt76/mt7615/main.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ static int mt7615_add_interface(struct ieee80211_hw *hw,
222222

223223
idx = MT7615_WTBL_RESERVED - mvif->mt76.idx;
224224

225-
INIT_LIST_HEAD(&mvif->sta.poll_list);
225+
INIT_LIST_HEAD(&mvif->sta.wcid.poll_list);
226226
mvif->sta.wcid.idx = idx;
227227
mvif->sta.wcid.phy_idx = mvif->mt76.band_idx;
228228
mvif->sta.wcid.hw_key_idx = -1;
@@ -275,8 +275,8 @@ static void mt7615_remove_interface(struct ieee80211_hw *hw,
275275
mt7615_mutex_release(dev);
276276

277277
spin_lock_bh(&dev->mt76.sta_poll_lock);
278-
if (!list_empty(&msta->poll_list))
279-
list_del_init(&msta->poll_list);
278+
if (!list_empty(&msta->wcid.poll_list))
279+
list_del_init(&msta->wcid.poll_list);
280280
spin_unlock_bh(&dev->mt76.sta_poll_lock);
281281

282282
mt76_packet_id_flush(&dev->mt76, &mvif->sta.wcid);
@@ -657,7 +657,7 @@ int mt7615_mac_sta_add(struct mt76_dev *mdev, struct ieee80211_vif *vif,
657657
if (idx < 0)
658658
return -ENOSPC;
659659

660-
INIT_LIST_HEAD(&msta->poll_list);
660+
INIT_LIST_HEAD(&msta->wcid.poll_list);
661661
msta->vif = mvif;
662662
msta->wcid.sta = 1;
663663
msta->wcid.idx = idx;
@@ -706,8 +706,8 @@ void mt7615_mac_sta_remove(struct mt76_dev *mdev, struct ieee80211_vif *vif,
706706
mt7615_mcu_add_bss_info(phy, vif, sta, false);
707707

708708
spin_lock_bh(&mdev->sta_poll_lock);
709-
if (!list_empty(&msta->poll_list))
710-
list_del_init(&msta->poll_list);
709+
if (!list_empty(&msta->wcid.poll_list))
710+
list_del_init(&msta->wcid.poll_list);
711711
spin_unlock_bh(&mdev->sta_poll_lock);
712712

713713
mt76_connac_power_save_sched(phy->mt76, &dev->pm);

drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ struct mt7615_sta {
125125

126126
struct mt7615_vif *vif;
127127

128-
struct list_head poll_list;
129128
u32 airtime_ac[8];
130129

131130
struct ieee80211_tx_rate rates[4];

0 commit comments

Comments
 (0)