Skip to content

Commit 9e9b18b

Browse files
bijudassravnborg
authored andcommitted
drm/bridge: lvds-codec: Add support for regulator
Add the support for enabling optional regulator that may be used as VCC source. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> [Replaced 'error' variable with 'ret'] [Renamed regulator from 'vcc' to 'power'] Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20200922105526.5252-1-laurent.pinchart+renesas@ideasonboard.com
1 parent 7488555 commit 9e9b18b

File tree

1 file changed

+29
-0
lines changed

1 file changed

+29
-0
lines changed

drivers/gpu/drm/bridge/lvds-codec.c

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,16 @@
1010
#include <linux/of_device.h>
1111
#include <linux/of_graph.h>
1212
#include <linux/platform_device.h>
13+
#include <linux/regulator/consumer.h>
1314

1415
#include <drm/drm_bridge.h>
1516
#include <drm/drm_panel.h>
1617

1718
struct lvds_codec {
19+
struct device *dev;
1820
struct drm_bridge bridge;
1921
struct drm_bridge *panel_bridge;
22+
struct regulator *vcc;
2023
struct gpio_desc *powerdown_gpio;
2124
u32 connector_type;
2225
};
@@ -38,6 +41,14 @@ static int lvds_codec_attach(struct drm_bridge *bridge,
3841
static void lvds_codec_enable(struct drm_bridge *bridge)
3942
{
4043
struct lvds_codec *lvds_codec = to_lvds_codec(bridge);
44+
int ret;
45+
46+
ret = regulator_enable(lvds_codec->vcc);
47+
if (ret) {
48+
dev_err(lvds_codec->dev,
49+
"Failed to enable regulator \"vcc\": %d\n", ret);
50+
return;
51+
}
4152

4253
if (lvds_codec->powerdown_gpio)
4354
gpiod_set_value_cansleep(lvds_codec->powerdown_gpio, 0);
@@ -46,9 +57,15 @@ static void lvds_codec_enable(struct drm_bridge *bridge)
4657
static void lvds_codec_disable(struct drm_bridge *bridge)
4758
{
4859
struct lvds_codec *lvds_codec = to_lvds_codec(bridge);
60+
int ret;
4961

5062
if (lvds_codec->powerdown_gpio)
5163
gpiod_set_value_cansleep(lvds_codec->powerdown_gpio, 1);
64+
65+
ret = regulator_disable(lvds_codec->vcc);
66+
if (ret)
67+
dev_err(lvds_codec->dev,
68+
"Failed to disable regulator \"vcc\": %d\n", ret);
5269
}
5370

5471
static const struct drm_bridge_funcs funcs = {
@@ -63,12 +80,24 @@ static int lvds_codec_probe(struct platform_device *pdev)
6380
struct device_node *panel_node;
6481
struct drm_panel *panel;
6582
struct lvds_codec *lvds_codec;
83+
int ret;
6684

6785
lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL);
6886
if (!lvds_codec)
6987
return -ENOMEM;
7088

89+
lvds_codec->dev = &pdev->dev;
7190
lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev);
91+
92+
lvds_codec->vcc = devm_regulator_get(lvds_codec->dev, "power");
93+
if (IS_ERR(lvds_codec->vcc)) {
94+
ret = PTR_ERR(lvds_codec->vcc);
95+
if (ret != -EPROBE_DEFER)
96+
dev_err(lvds_codec->dev,
97+
"Unable to get \"vcc\" supply: %d\n", ret);
98+
return ret;
99+
}
100+
72101
lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown",
73102
GPIOD_OUT_HIGH);
74103
if (IS_ERR(lvds_codec->powerdown_gpio))

0 commit comments

Comments
 (0)