Skip to content

Commit aad22ca

Browse files
Rex Zhualexdeucher
authored andcommitted
drm/amdgpu: refine amdgpu pwm1_enable sysfs interface.
Make the interface consistent. Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 4f93f09 commit aad22ca

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -867,8 +867,7 @@ static ssize_t amdgpu_hwmon_get_pwm1_enable(struct device *dev,
867867

868868
pwm_mode = amdgpu_dpm_get_fan_control_mode(adev);
869869

870-
/* never 0 (full-speed), fuse or smc-controlled always */
871-
return sprintf(buf, "%i\n", pwm_mode == FDO_PWM_MODE_STATIC ? 1 : 2);
870+
return sprintf(buf, "%i\n", pwm_mode);
872871
}
873872

874873
static ssize_t amdgpu_hwmon_set_pwm1_enable(struct device *dev,
@@ -887,14 +886,7 @@ static ssize_t amdgpu_hwmon_set_pwm1_enable(struct device *dev,
887886
if (err)
888887
return err;
889888

890-
switch (value) {
891-
case 1: /* manual, percent-based */
892-
amdgpu_dpm_set_fan_control_mode(adev, FDO_PWM_MODE_STATIC);
893-
break;
894-
default: /* disable */
895-
amdgpu_dpm_set_fan_control_mode(adev, 0);
896-
break;
897-
}
889+
amdgpu_dpm_set_fan_control_mode(adev, value);
898890

899891
return count;
900892
}

0 commit comments

Comments
 (0)