Skip to content

Commit aaebea9

Browse files
zhijianli88Alexander Gordeev
authored andcommitted
s390/cio: convert sprintf()/snprintf() to sysfs_emit()
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). Generally, this patch is generated by make coccicheck M=<path/to/file> MODE=patch \ COCCI=scripts/coccinelle/api/device_attr_show.cocci No functional change intended. Cc: Vineeth Vijayan <vneethv@linux.ibm.com> Cc: Peter Oberparleiter <oberpar@linux.ibm.com> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> Link: https://lore.kernel.org/r/20240314095209.1325229-1-lizhijian@fujitsu.com Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
1 parent b3840c8 commit aaebea9

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/s390/cio/css.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ static ssize_t type_show(struct device *dev, struct device_attribute *attr,
309309
{
310310
struct subchannel *sch = to_subchannel(dev);
311311

312-
return sprintf(buf, "%01x\n", sch->st);
312+
return sysfs_emit(buf, "%01x\n", sch->st);
313313
}
314314

315315
static DEVICE_ATTR_RO(type);
@@ -319,7 +319,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
319319
{
320320
struct subchannel *sch = to_subchannel(dev);
321321

322-
return sprintf(buf, "css:t%01X\n", sch->st);
322+
return sysfs_emit(buf, "css:t%01X\n", sch->st);
323323
}
324324

325325
static DEVICE_ATTR_RO(modalias);
@@ -345,7 +345,7 @@ static ssize_t driver_override_show(struct device *dev,
345345
ssize_t len;
346346

347347
device_lock(dev);
348-
len = snprintf(buf, PAGE_SIZE, "%s\n", sch->driver_override);
348+
len = sysfs_emit(buf, "%s\n", sch->driver_override);
349349
device_unlock(dev);
350350
return len;
351351
}
@@ -396,8 +396,8 @@ static ssize_t pimpampom_show(struct device *dev,
396396
struct subchannel *sch = to_subchannel(dev);
397397
struct pmcw *pmcw = &sch->schib.pmcw;
398398

399-
return sprintf(buf, "%02x %02x %02x\n",
400-
pmcw->pim, pmcw->pam, pmcw->pom);
399+
return sysfs_emit(buf, "%02x %02x %02x\n",
400+
pmcw->pim, pmcw->pam, pmcw->pom);
401401
}
402402
static DEVICE_ATTR_RO(pimpampom);
403403

@@ -881,7 +881,7 @@ static ssize_t real_cssid_show(struct device *dev, struct device_attribute *a,
881881
if (!css->id_valid)
882882
return -EINVAL;
883883

884-
return sprintf(buf, "%x\n", css->cssid);
884+
return sysfs_emit(buf, "%x\n", css->cssid);
885885
}
886886
static DEVICE_ATTR_RO(real_cssid);
887887

@@ -904,7 +904,7 @@ static ssize_t cm_enable_show(struct device *dev, struct device_attribute *a,
904904
int ret;
905905

906906
mutex_lock(&css->mutex);
907-
ret = sprintf(buf, "%x\n", css->cm_enabled);
907+
ret = sysfs_emit(buf, "%x\n", css->cm_enabled);
908908
mutex_unlock(&css->mutex);
909909
return ret;
910910
}

0 commit comments

Comments
 (0)