Skip to content

Commit ab5d964

Browse files
committed
drm/i915/selftests: mark up hugepages object with start_cpu_write
Just like we do for internal objects. Also just use i915_gem_object_set_cache_coherency() here. No need for over-flushing on LLC platforms. Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20211018174508.2137279-9-matthew.auld@intel.com
1 parent 3884d8a commit ab5d964

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/gpu/drm/i915/gem/selftests/huge_pages.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,8 @@ static void put_huge_pages(struct drm_i915_gem_object *obj,
136136
huge_pages_free_pages(pages);
137137

138138
obj->mm.dirty = false;
139+
140+
__start_cpu_write(obj);
139141
}
140142

141143
static const struct drm_i915_gem_object_ops huge_page_ops = {
@@ -152,6 +154,7 @@ huge_pages_object(struct drm_i915_private *i915,
152154
{
153155
static struct lock_class_key lock_class;
154156
struct drm_i915_gem_object *obj;
157+
unsigned int cache_level;
155158

156159
GEM_BUG_ON(!size);
157160
GEM_BUG_ON(!IS_ALIGNED(size, BIT(__ffs(page_mask))));
@@ -173,7 +176,9 @@ huge_pages_object(struct drm_i915_private *i915,
173176

174177
obj->write_domain = I915_GEM_DOMAIN_CPU;
175178
obj->read_domains = I915_GEM_DOMAIN_CPU;
176-
obj->cache_level = I915_CACHE_NONE;
179+
180+
cache_level = HAS_LLC(i915) ? I915_CACHE_LLC : I915_CACHE_NONE;
181+
i915_gem_object_set_cache_coherency(obj, cache_level);
177182

178183
obj->mm.page_mask = page_mask;
179184

0 commit comments

Comments
 (0)