net: bcmgenet: Return PTR_ERR() for fixed_phy_register()

Ruan Jinjie · davem330 · commit acf50d1adbf4 · 2023-08-20T15:13:27.000+01:00
fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY,
etc, in addition to -ENODEV. The Best practice is to return these
error codes with PTR_ERR().

Signed-off-by: Ruan Jinjie &lt;ruanjinjie@huawei.com&gt;
Acked-by: Doug Berger &lt;opendmb@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -619,7 +619,7 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv)
 		phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);
 		if (!phydev || IS_ERR(phydev)) {
 			dev_err(kdev, "failed to register fixed PHY device\n");
-			return -ENODEV;
+			return PTR_ERR(phydev);
 		}
 
 		/* Make sure we initialize MoCA PHYs with a link down */

Original file line number	Diff line number	Diff line change
`@@ -619,7 +619,7 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv)`
`619`	`619`	`phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);`
`620`	`620`	`if (!phydev \|\| IS_ERR(phydev)) {`
`621`	`621`	`dev_err(kdev, "failed to register fixed PHY device\n");`
`622`		`- return -ENODEV;`
	`622`	`+ return PTR_ERR(phydev);`
`623`	`623`	`}`
`624`	`624`
`625`	`625`	`/* Make sure we initialize MoCA PHYs with a link down */`