@@ -224,7 +224,9 @@ static void sdma_v7_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)
224224 * sdma_v7_0_ring_emit_ib - Schedule an IB on the DMA engine
225225 *
226226 * @ring: amdgpu ring pointer
227+ * @job: job to retrieve vmid from
227228 * @ib: IB object to schedule
229+ * @flags: unused
228230 *
229231 * Schedule an IB in the DMA ring.
230232 */
@@ -260,8 +262,6 @@ static void sdma_v7_0_ring_emit_ib(struct amdgpu_ring *ring,
260262 * sdma_v7_0_ring_emit_mem_sync - flush the IB by graphics cache rinse
261263 *
262264 * @ring: amdgpu ring pointer
263- * @job: job to retrieve vmid from
264- * @ib: IB object to schedule
265265 *
266266 * flush the IB by graphics cache rinse.
267267 */
@@ -313,7 +313,9 @@ static void sdma_v7_0_ring_emit_hdp_flush(struct amdgpu_ring *ring)
313313 * sdma_v7_0_ring_emit_fence - emit a fence on the DMA ring
314314 *
315315 * @ring: amdgpu ring pointer
316- * @fence: amdgpu fence object
316+ * @addr: address
317+ * @seq: fence seq number
318+ * @flags: fence flags
317319 *
318320 * Add a DMA fence packet to the ring to write
319321 * the fence seq number and DMA trap packet to generate
@@ -915,6 +917,7 @@ static int sdma_v7_0_ring_test_ring(struct amdgpu_ring *ring)
915917 * sdma_v7_0_ring_test_ib - test an IB on the DMA engine
916918 *
917919 * @ring: amdgpu_ring structure holding ring information
920+ * @timeout: timeout value in jiffies, or MAX_SCHEDULE_TIMEOUT
918921 *
919922 * Test a simple IB in the DMA ring.
920923 * Returns 0 on success, error on failure.
@@ -1038,10 +1041,9 @@ static void sdma_v7_0_vm_copy_pte(struct amdgpu_ib *ib,
10381041 *
10391042 * @ib: indirect buffer to fill with commands
10401043 * @pe: addr of the page entry
1041- * @addr : dst addr to write into pe
1044+ * @value : dst addr to write into pe
10421045 * @count: number of page entries to update
10431046 * @incr: increase next addr by incr bytes
1044- * @flags: access flags
10451047 *
10461048 * Update PTEs by writing them manually using sDMA.
10471049 */
@@ -1095,6 +1097,8 @@ static void sdma_v7_0_vm_set_pte_pde(struct amdgpu_ib *ib,
10951097
10961098/**
10971099 * sdma_v7_0_ring_pad_ib - pad the IB
1100+ *
1101+ * @ring: amdgpu ring pointer
10981102 * @ib: indirect buffer to fill with padding
10991103 *
11001104 * Pad the IB with NOPs to a boundary multiple of 8.
@@ -1145,7 +1149,8 @@ static void sdma_v7_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)
11451149 * sdma_v7_0_ring_emit_vm_flush - vm flush using sDMA
11461150 *
11471151 * @ring: amdgpu_ring pointer
1148- * @vm: amdgpu_vm pointer
1152+ * @vmid: vmid number to use
1153+ * @pd_addr: address
11491154 *
11501155 * Update the page table base and flush the VM TLB
11511156 * using sDMA.
@@ -1549,11 +1554,11 @@ static void sdma_v7_0_set_irq_funcs(struct amdgpu_device *adev)
15491554/**
15501555 * sdma_v7_0_emit_copy_buffer - copy buffer using the sDMA engine
15511556 *
1552- * @ring: amdgpu_ring structure holding ring information
1557+ * @ib: indirect buffer to fill with commands
15531558 * @src_offset: src GPU address
15541559 * @dst_offset: dst GPU address
15551560 * @byte_count: number of bytes to xfer
1556- * @copy_flags: flags for the copy
1561+ * @copy_flags: copy flags for the buffers
15571562 *
15581563 * Copy GPU buffers using the DMA engine.
15591564 * Used by the amdgpu ttm implementation to move pages if
@@ -1579,7 +1584,7 @@ static void sdma_v7_0_emit_copy_buffer(struct amdgpu_ib *ib,
15791584/**
15801585 * sdma_v7_0_emit_fill_buffer - fill buffer using the sDMA engine
15811586 *
1582- * @ring: amdgpu_ring structure holding ring information
1587+ * @ib: indirect buffer to fill
15831588 * @src_data: value to write to buffer
15841589 * @dst_offset: dst GPU address
15851590 * @byte_count: number of bytes to xfer
0 commit comments