Skip to content

Commit b7a52fa

Browse files
Ralph WuerthnerJames Bottomley
authored andcommitted
[SCSI] zfcp: print bit error threshold data human readable
Replace hex dump of bit error threshold data by log message showing bit error threshold data human readable. Signed-off-by: Ralph Wuerthner <rwuerthn@de.ibm.com> Signed-off-by: Andreas Herrmann <aherrman@de.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
1 parent 06506d0 commit b7a52fa

File tree

1 file changed

+32
-4
lines changed

1 file changed

+32
-4
lines changed

drivers/s390/scsi/zfcp_fsf.c

Lines changed: 32 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -866,6 +866,7 @@ zfcp_fsf_status_read_handler(struct zfcp_fsf_req *fsf_req)
866866
struct zfcp_adapter *adapter = fsf_req->adapter;
867867
struct fsf_status_read_buffer *status_buffer =
868868
(struct fsf_status_read_buffer *) fsf_req->data;
869+
struct fsf_bit_error_payload *fsf_bit_error;
869870

870871
if (fsf_req->status & ZFCP_STATUS_FSFREQ_DISMISSED) {
871872
zfcp_hba_dbf_event_fsf_unsol("dism", adapter, status_buffer);
@@ -892,10 +893,37 @@ zfcp_fsf_status_read_handler(struct zfcp_fsf_req *fsf_req)
892893
break;
893894

894895
case FSF_STATUS_READ_BIT_ERROR_THRESHOLD:
895-
ZFCP_LOG_NORMAL("Bit error threshold data received:\n");
896-
ZFCP_HEX_DUMP(ZFCP_LOG_LEVEL_NORMAL,
897-
(char *) status_buffer,
898-
sizeof (struct fsf_status_read_buffer));
896+
fsf_bit_error = (struct fsf_bit_error_payload *)
897+
status_buffer->payload;
898+
ZFCP_LOG_NORMAL("Warning: bit error threshold data "
899+
"received (adapter %s, "
900+
"link failures = %i, loss of sync errors = %i, "
901+
"loss of signal errors = %i, "
902+
"primitive sequence errors = %i, "
903+
"invalid transmission word errors = %i, "
904+
"CRC errors = %i)\n",
905+
zfcp_get_busid_by_adapter(adapter),
906+
fsf_bit_error->link_failure_error_count,
907+
fsf_bit_error->loss_of_sync_error_count,
908+
fsf_bit_error->loss_of_signal_error_count,
909+
fsf_bit_error->primitive_sequence_error_count,
910+
fsf_bit_error->invalid_transmission_word_error_count,
911+
fsf_bit_error->crc_error_count);
912+
ZFCP_LOG_INFO("Additional bit error threshold data "
913+
"(adapter %s, "
914+
"primitive sequence event time-outs = %i, "
915+
"elastic buffer overrun errors = %i, "
916+
"advertised receive buffer-to-buffer credit = %i, "
917+
"current receice buffer-to-buffer credit = %i, "
918+
"advertised transmit buffer-to-buffer credit = %i, "
919+
"current transmit buffer-to-buffer credit = %i)\n",
920+
zfcp_get_busid_by_adapter(adapter),
921+
fsf_bit_error->primitive_sequence_event_timeout_count,
922+
fsf_bit_error->elastic_buffer_overrun_error_count,
923+
fsf_bit_error->advertised_receive_b2b_credit,
924+
fsf_bit_error->current_receive_b2b_credit,
925+
fsf_bit_error->advertised_transmit_b2b_credit,
926+
fsf_bit_error->current_transmit_b2b_credit);
899927
break;
900928

901929
case FSF_STATUS_READ_LINK_DOWN:

0 commit comments

Comments
 (0)