Skip to content

Commit b875f99

Browse files
Shannon NelsonJeff Kirsher
authored andcommitted
i40e: Change BUG_ON to WARN_ON in service event complete
There's no need to kill the thread and eventually the kernel in this case. In fact, the remainder of the code won't hurt anything anyway, so just complain that we're here and move along. Prompted by a recent Linus diatribe. Change-ID: Iec020d8bcfedffc1cd2553cc6905fd915bb3e670 Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
1 parent 9c883bd commit b875f99

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/intel/i40e/i40e_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5738,7 +5738,7 @@ static void i40e_handle_lan_overflow_event(struct i40e_pf *pf,
57385738
**/
57395739
static void i40e_service_event_complete(struct i40e_pf *pf)
57405740
{
5741-
BUG_ON(!test_bit(__I40E_SERVICE_SCHED, &pf->state));
5741+
WARN_ON(!test_bit(__I40E_SERVICE_SCHED, &pf->state));
57425742

57435743
/* flush memory to make sure state is correct before next watchog */
57445744
smp_mb__before_atomic();

0 commit comments

Comments
 (0)