Skip to content

Commit b9f3082

Browse files
Dave Chinnerdchinner
authored andcommitted
xfs: convert quota options flags to unsigned.
5.18 w/ std=gnu11 compiled with gcc-5 wants flags stored in unsigned fields to be unsigned. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Chandan Babu R <chandan.babu@oracle.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
1 parent 90215d7 commit b9f3082

File tree

2 files changed

+31
-30
lines changed

2 files changed

+31
-30
lines changed

fs/xfs/libxfs/xfs_quota_defs.h

Lines changed: 31 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -73,29 +73,45 @@ typedef uint8_t xfs_dqtype_t;
7373
* to a single function. None of these XFS_QMOPT_* flags are meant to have
7474
* persistent values (ie. their values can and will change between versions)
7575
*/
76-
#define XFS_QMOPT_UQUOTA 0x0000004 /* user dquot requested */
77-
#define XFS_QMOPT_PQUOTA 0x0000008 /* project dquot requested */
78-
#define XFS_QMOPT_FORCE_RES 0x0000010 /* ignore quota limits */
79-
#define XFS_QMOPT_SBVERSION 0x0000040 /* change superblock version num */
80-
#define XFS_QMOPT_GQUOTA 0x0002000 /* group dquot requested */
76+
#define XFS_QMOPT_UQUOTA (1u << 0) /* user dquot requested */
77+
#define XFS_QMOPT_GQUOTA (1u << 1) /* group dquot requested */
78+
#define XFS_QMOPT_PQUOTA (1u << 2) /* project dquot requested */
79+
#define XFS_QMOPT_FORCE_RES (1u << 3) /* ignore quota limits */
80+
#define XFS_QMOPT_SBVERSION (1u << 4) /* change superblock version num */
8181

8282
/*
8383
* flags to xfs_trans_mod_dquot to indicate which field needs to be
8484
* modified.
8585
*/
86-
#define XFS_QMOPT_RES_REGBLKS 0x0010000
87-
#define XFS_QMOPT_RES_RTBLKS 0x0020000
88-
#define XFS_QMOPT_BCOUNT 0x0040000
89-
#define XFS_QMOPT_ICOUNT 0x0080000
90-
#define XFS_QMOPT_RTBCOUNT 0x0100000
91-
#define XFS_QMOPT_DELBCOUNT 0x0200000
92-
#define XFS_QMOPT_DELRTBCOUNT 0x0400000
93-
#define XFS_QMOPT_RES_INOS 0x0800000
86+
#define XFS_QMOPT_RES_REGBLKS (1u << 7)
87+
#define XFS_QMOPT_RES_RTBLKS (1u << 8)
88+
#define XFS_QMOPT_BCOUNT (1u << 9)
89+
#define XFS_QMOPT_ICOUNT (1u << 10)
90+
#define XFS_QMOPT_RTBCOUNT (1u << 11)
91+
#define XFS_QMOPT_DELBCOUNT (1u << 12)
92+
#define XFS_QMOPT_DELRTBCOUNT (1u << 13)
93+
#define XFS_QMOPT_RES_INOS (1u << 14)
9494

9595
/*
9696
* flags for dqalloc.
9797
*/
98-
#define XFS_QMOPT_INHERIT 0x1000000
98+
#define XFS_QMOPT_INHERIT (1u << 31)
99+
100+
#define XFS_QMOPT_FLAGS \
101+
{ XFS_QMOPT_UQUOTA, "UQUOTA" }, \
102+
{ XFS_QMOPT_PQUOTA, "PQUOTA" }, \
103+
{ XFS_QMOPT_FORCE_RES, "FORCE_RES" }, \
104+
{ XFS_QMOPT_SBVERSION, "SBVERSION" }, \
105+
{ XFS_QMOPT_GQUOTA, "GQUOTA" }, \
106+
{ XFS_QMOPT_INHERIT, "INHERIT" }, \
107+
{ XFS_QMOPT_RES_REGBLKS, "RES_REGBLKS" }, \
108+
{ XFS_QMOPT_RES_RTBLKS, "RES_RTBLKS" }, \
109+
{ XFS_QMOPT_BCOUNT, "BCOUNT" }, \
110+
{ XFS_QMOPT_ICOUNT, "ICOUNT" }, \
111+
{ XFS_QMOPT_RTBCOUNT, "RTBCOUNT" }, \
112+
{ XFS_QMOPT_DELBCOUNT, "DELBCOUNT" }, \
113+
{ XFS_QMOPT_DELRTBCOUNT, "DELRTBCOUNT" }, \
114+
{ XFS_QMOPT_RES_INOS, "RES_INOS" }
99115

100116
/*
101117
* flags to xfs_trans_mod_dquot.
@@ -114,6 +130,7 @@ typedef uint8_t xfs_dqtype_t;
114130
(XFS_QMOPT_UQUOTA | XFS_QMOPT_PQUOTA | XFS_QMOPT_GQUOTA)
115131
#define XFS_QMOPT_RESBLK_MASK (XFS_QMOPT_RES_REGBLKS | XFS_QMOPT_RES_RTBLKS)
116132

133+
117134
extern xfs_failaddr_t xfs_dquot_verify(struct xfs_mount *mp,
118135
struct xfs_disk_dquot *ddq, xfs_dqid_t id);
119136
extern xfs_failaddr_t xfs_dqblk_verify(struct xfs_mount *mp,

fs/xfs/xfs_trace.h

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1096,22 +1096,6 @@ DEFINE_DQUOT_EVENT(xfs_dqflush_done);
10961096
DEFINE_DQUOT_EVENT(xfs_trans_apply_dquot_deltas_before);
10971097
DEFINE_DQUOT_EVENT(xfs_trans_apply_dquot_deltas_after);
10981098

1099-
#define XFS_QMOPT_FLAGS \
1100-
{ XFS_QMOPT_UQUOTA, "UQUOTA" }, \
1101-
{ XFS_QMOPT_PQUOTA, "PQUOTA" }, \
1102-
{ XFS_QMOPT_FORCE_RES, "FORCE_RES" }, \
1103-
{ XFS_QMOPT_SBVERSION, "SBVERSION" }, \
1104-
{ XFS_QMOPT_GQUOTA, "GQUOTA" }, \
1105-
{ XFS_QMOPT_INHERIT, "INHERIT" }, \
1106-
{ XFS_QMOPT_RES_REGBLKS, "RES_REGBLKS" }, \
1107-
{ XFS_QMOPT_RES_RTBLKS, "RES_RTBLKS" }, \
1108-
{ XFS_QMOPT_BCOUNT, "BCOUNT" }, \
1109-
{ XFS_QMOPT_ICOUNT, "ICOUNT" }, \
1110-
{ XFS_QMOPT_RTBCOUNT, "RTBCOUNT" }, \
1111-
{ XFS_QMOPT_DELBCOUNT, "DELBCOUNT" }, \
1112-
{ XFS_QMOPT_DELRTBCOUNT, "DELRTBCOUNT" }, \
1113-
{ XFS_QMOPT_RES_INOS, "RES_INOS" }
1114-
11151099
TRACE_EVENT(xfs_trans_mod_dquot,
11161100
TP_PROTO(struct xfs_trans *tp, struct xfs_dquot *dqp,
11171101
unsigned int field, int64_t delta),

0 commit comments

Comments
 (0)