Skip to content

Commit bb78976

Browse files
RDS: mark few internal functions static to make sparse build happy
Fixes below warnings: warning: symbol 'rds_send_probe' was not declared. Should it be static? warning: symbol 'rds_send_ping' was not declared. Should it be static? warning: symbol 'rds_tcp_accept_one_path' was not declared. Should it be static? warning: symbol 'rds_walk_conn_path_info' was not declared. Should it be static? Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
1 parent f69b22e commit bb78976

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

net/rds/connection.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -545,11 +545,11 @@ void rds_for_each_conn_info(struct socket *sock, unsigned int len,
545545
}
546546
EXPORT_SYMBOL_GPL(rds_for_each_conn_info);
547547

548-
void rds_walk_conn_path_info(struct socket *sock, unsigned int len,
549-
struct rds_info_iterator *iter,
550-
struct rds_info_lengths *lens,
551-
int (*visitor)(struct rds_conn_path *, void *),
552-
size_t item_len)
548+
static void rds_walk_conn_path_info(struct socket *sock, unsigned int len,
549+
struct rds_info_iterator *iter,
550+
struct rds_info_lengths *lens,
551+
int (*visitor)(struct rds_conn_path *, void *),
552+
size_t item_len)
553553
{
554554
u64 buffer[(item_len + 7) / 8];
555555
struct hlist_head *head;

net/rds/send.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1169,7 +1169,7 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
11691169
* or
11701170
* RDS_FLAG_HB_PONG|RDS_FLAG_ACK_REQUIRED
11711171
*/
1172-
int
1172+
static int
11731173
rds_send_probe(struct rds_conn_path *cp, __be16 sport,
11741174
__be16 dport, u8 h_flags)
11751175
{
@@ -1238,7 +1238,7 @@ rds_send_pong(struct rds_conn_path *cp, __be16 dport)
12381238
return rds_send_probe(cp, 0, dport, 0);
12391239
}
12401240

1241-
void
1241+
static void
12421242
rds_send_ping(struct rds_connection *conn)
12431243
{
12441244
unsigned long flags;

net/rds/tcp_listen.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ int rds_tcp_keepalive(struct socket *sock)
7979
* smaller ip address, we recycle conns in RDS_CONN_ERROR on the passive side
8080
* by moving them to CONNECTING in this function.
8181
*/
82+
static
8283
struct rds_tcp_connection *rds_tcp_accept_one_path(struct rds_connection *conn)
8384
{
8485
int i;

0 commit comments

Comments
 (0)