serdev: fix memleak on module unload

jhovold · gregkh · commit bc6cf3669d22 · 2018-06-28T21:34:39.000+09:00
Make sure to free all resources associated with the ida on module exit. Fixes: cd6484e ("serdev: Introduce new bus for serial attached devices") Cc: stable <stable@vger.kernel.org> # 4.11 Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
@@ -617,6 +617,7 @@ EXPORT_SYMBOL_GPL(__serdev_device_driver_register);
 static void __exit serdev_exit(void)
 {
 	bus_unregister(&serdev_bus_type);
+	ida_destroy(&ctrl_ida);
 }
 module_exit(serdev_exit);
 

Original file line number	Diff line number	Diff line change
`@@ -617,6 +617,7 @@ EXPORT_SYMBOL_GPL(__serdev_device_driver_register);`
`617`	`617`	`static void __exit serdev_exit(void)`
`618`	`618`	`{`
`619`	`619`	`bus_unregister(&serdev_bus_type);`
	`620`	`+ ida_destroy(&ctrl_ida);`
`620`	`621`	`}`
`621`	`622`	`module_exit(serdev_exit);`
`622`	`623`