Skip to content

Commit bceee75

Browse files
committed
ALSA: usb-audio: Disable low-latency mode for implicit feedback sync
When a playback stream runs in the implicit feedback mode, its operation is passive and won't start unless the capture packet is received. This behavior contradicts with the low-latency playback mode, and we should turn off lowlatency_playback flag accordingly. In theory, we may take the low-latency mode when the playback-first quirk is set, but it still conflicts with the later operation with the fixed packet numbers, so it's disabled all together for now. Link: https://lore.kernel.org/r/20210929080844.11583-6-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent e581f1c commit bceee75

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

sound/usb/pcm.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,9 @@ static int lowlatency_playback_available(struct snd_pcm_runtime *runtime,
595595
/* free-wheeling mode? (e.g. dmix) */
596596
if (runtime->stop_threshold > runtime->buffer_size)
597597
return false;
598+
/* implicit feedback mode has own operation mode */
599+
if (snd_usb_endpoint_implicit_feedback_sink(subs->data_endpoint))
600+
return false;
598601
/* too short periods? */
599602
if (subs->data_endpoint->nominal_queue_size >= subs->buffer_bytes)
600603
return false;

0 commit comments

Comments
 (0)