net: ag71xx: add missed clk_disable_unprepare in error path of probe

Huang Guobin · davem330 · commit befc113c56a7 · 2020-07-20T18:37:38.000-07:00
The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when of_reset_control_get_exclusive() failed. Add the missed call to fix it. Fixes: d51b6ce ("net: ethernet: add ag71xx driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Huang Guobin <huangguobin4@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
@@ -556,7 +556,8 @@ static int ag71xx_mdio_probe(struct ag71xx *ag)
 	ag->mdio_reset = of_reset_control_get_exclusive(np, "mdio");
 	if (IS_ERR(ag->mdio_reset)) {
 		netif_err(ag, probe, ndev, "Failed to get reset mdio.\n");
-		return PTR_ERR(ag->mdio_reset);
+		err = PTR_ERR(ag->mdio_reset);
+		goto mdio_err_put_clk;
 	}
 
 	mii_bus->name = "ag71xx_mdio";

Original file line number	Diff line number	Diff line change
`@@ -556,7 +556,8 @@ static int ag71xx_mdio_probe(struct ag71xx *ag)`
`556`	`556`	`ag->mdio_reset = of_reset_control_get_exclusive(np, "mdio");`
`557`	`557`	`if (IS_ERR(ag->mdio_reset)) {`
`558`	`558`	`netif_err(ag, probe, ndev, "Failed to get reset mdio.\n");`
`559`		`- return PTR_ERR(ag->mdio_reset);`
	`559`	`+ err = PTR_ERR(ag->mdio_reset);`
	`560`	`+ goto mdio_err_put_clk;`
`560`	`561`	`}`
`561`	`562`
`562`	`563`	`mii_bus->name = "ag71xx_mdio";`